Repository navigation
fix: report the real version, add --socket, and refuse mismatched release tags - #4
Merged
Merged
Conversation
…ease tags The v0.3.0 and v0.4.0 binaries were built from their tags, but Cargo.toml was never bumped past 0.2.0, so `-V` printed 0.2.0 (#3). Bump to 0.5.0, and make the release workflow fail when the tag and Cargo.toml disagree. The README documented `--socket`, which never existed: the agent only served gRPC on 0.0.0.0:50051. Add it, the same way the ratelimit and waf agents do: `--socket <PATH>` (or TRANSFORM_SOCKET) serves the v2 protocol over UDS. Without it, the agent still listens for gRPC on 0.0.0.0:50051, so existing deployments are unchanged. The two flags are mutually exclusive. Verified end to end against zentinel 26.10_5, with a rule that sets a response header. Over `--socket` with `unix-socket` in the KDL, and over the gRPC default with `grpc "http://127.0.0.1:50051"`, the response carries the header. README: the CLI options now match `--help`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3.
Version. The v0.3.0 and v0.4.0 binaries were built from their tags, but
Cargo.tomlwas still at 0.2.0, so-Vprinted 0.2.0.--socketis new.release.ymlnow fails the build when the tag andCargo.tomldisagree, so this can't recur.--socket. The README documented it, but it never existed; the agent only served gRPC.--socket <PATH>(envTRANSFORM_SOCKET) now serves the v2 protocol over UDS, the same way the ratelimit and waf agents do.0.0.0.0:50051, so existing deployments are unchanged. The two flags are mutually exclusive.README. The CLI options now match
--help, with a note on the gRPC KDL form.Verified end to end against zentinel 26.10_5, with a rule that sets a response header:
--socket /tmp/zt-xform.sockwithunix-socket "/tmp/zt-xform.sock"→ 200 withX-Transformed: yesgrpc "http://127.0.0.1:50051"→ 200 withX-Transformed: yesfmt, clippy
-D warningsandcargo testall pass. Issue #3 stays open until a v0.5.0 release ships the new binary.