Repository navigation
gpui: Defer native window close cleanup to avoid reentrant app borrow - #66181
Open
Anthony-Eid wants to merge 1 commit into
Open
Anthony-Eid wants to merge 1 commit into
Anthony-Eid wants to merge 1 commit into
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defer the shared native window-close callback to a foreground task so Windows destruction messages can arrive while GPUI is borrowed without panicking or skipping cleanup. The task removes the window if still present, then removes its system tab; a regression test delivers the close notification while the app is borrowed and verifies cleanup after tasks drain. Opus 5.5 review passed, and the focused test passed after rebasing onto main (using Cargo after a Corgi Metal-toolchain failure); the Wasm check passed before rebasing. Native Windows behavior has not been exercised. Fixes FR-531, tracking ZED-CK4.
Release Notes: