Skip to content

http_client: Unify asset downloading logic - #66048

Open
MrSubidubi wants to merge 4 commits into
mainfrom
unify-downloading-logic
Open

MrSubidubi wants to merge 4 commits into
mainfrom
unify-downloading-logic

Conversation

@MrSubidubi

Copy link
Copy Markdown
Member

Supersedes #62653

Summary

This PR unifies the download handling we have in the http_client crate, because we were alternating between the ways we were downloading a lot, in one case we changed the way of downloading entirely if a hex digest was present or not.

With this in, we now handle this one way for all kinds of downloads, removing a lot of duplicated code and unifying the behavior here across download types.

Testing

Tested this manually.

Self-review

  • I've reviewed my diff for quality, security, reliability, and performance.
  • UI changes follow the checklist.
  • Tests cover the new or changed behavior.

Release Notes:

  • Improved reliability of language server and agent downloads by verifying checksums consistently, rejecting failed HTTP responses, and improving cleanup of partial downloads.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Oct 23, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Oct 23, 2026
@SomeoneToIgnore SomeoneToIgnore self-assigned this Oct 23, 2026
Comment thread crates/github_releases/src/github_releases.rs
Comment thread crates/http_client/src/github_download.rs Outdated
Comment thread crates/http_client/Cargo.toml
Comment thread crates/github_releases/src/github_releases.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants