Repository navigation
http_client: Unify asset downloading logic - #66048
Open
MrSubidubi wants to merge 4 commits into
Open
MrSubidubi wants to merge 4 commits into
MrSubidubi wants to merge 4 commits into
Conversation
SomeoneToIgnore
requested changes
Oct 23, 2026
SomeoneToIgnore
requested changes
Oct 26, 2026
SomeoneToIgnore
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #62653
Summary
This PR unifies the download handling we have in the http_client crate, because we were alternating between the ways we were downloading a lot, in one case we changed the way of downloading entirely if a hex digest was present or not.
With this in, we now handle this one way for all kinds of downloads, removing a lot of duplicated code and unifying the behavior here across download types.
Testing
Tested this manually.
Self-review
Release Notes: