Skip to content

languages: Avoid probing unresolved macOS Python shim - #62534

Merged
SomeoneToIgnore merged 1 commit into
zed-industries:mainfrom
cedws:fix/macos-python-clt-probe
Aug 12, 2026
Merged

languages: Avoid probing unresolved macOS Python shim#62534
SomeoneToIgnore merged 1 commit into
zed-industries:mainfrom
cedws:fix/macos-python-clt-probe

Conversation

@cedws

@cedws cedws commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Objective

Fixes #62529.

Prevent Python toolchain discovery from executing Apple's /usr/bin/python3 Command Line Tools shim when no active developer Python exists. Executing that unresolved shim causes macOS to repeatedly prompt users to install the Command Line Tools, even when Python is managed through Nix, uv, or pyenv.

Solution

Update Python Environment Tools (PET) to bb8e046, which includes microsoft/python-environment-tools#506. That upstream change resolves active Xcode and Command Line Tools Python executables from filesystem state and skips unresolved macOS system Python shims before generic process probing.

Adapt Zed to the updated PET API by:

  • displaying the newly supported Hatch environment kind
  • passing no refresh identifier when running in-process environment discovery

Testing

  • cargo check -p languages --locked
  • PET unit tests covering unresolved macOS system Python shims
  • The Zed compilation check was run on Linux; the original dialog reproduction was not manually tested on macOS.

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content adheres to Zed's UI standards (UX/UI and icon guidelines)
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed Python toolchain discovery prompting installation of Apple Command Line Tools when using a separately managed Python installation.

@cla-bot

cla-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @cedws on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Aug 12, 2026
@cedws

cedws commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Aug 12, 2026
@cla-bot

cla-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

osiewicz
osiewicz approved these changes Aug 12, 2026
View reviewed changes

@osiewicz osiewicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!

@SomeoneToIgnore
SomeoneToIgnore added this pull request to the merge queue Aug 12, 2026
Merged via the queue into zed-industries:main with commit 93f6b2e Aug 12, 2026
68 of 70 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 27, 2026
Open
playdohface pushed a commit to playdohface/zed that referenced this pull request Aug 29, 2026
@cedws @playdohface
languages: Avoid probing unresolved macOS Python shim (zed-industries…
2b68c57 
…#62534)

# Objective

Fixes zed-industries#62529.

Prevent Python toolchain discovery from executing Apple's
`/usr/bin/python3` Command Line Tools shim when no active developer
Python exists. Executing that unresolved shim causes macOS to repeatedly
prompt users to install the Command Line Tools, even when Python is
managed through Nix, uv, or pyenv.

## Solution

Update Python Environment Tools (PET) to `bb8e046`, which includes
microsoft/python-environment-tools#506. That upstream change resolves
active Xcode and Command Line Tools Python executables from filesystem
state and skips unresolved macOS system Python shims before generic
process probing.

Adapt Zed to the updated PET API by:

- displaying the newly supported Hatch environment kind
- passing no refresh identifier when running in-process environment
discovery

## Testing

- `cargo check -p languages --locked`
- PET unit tests covering unresolved macOS system Python shims
- The Zed compilation check was run on Linux; the original dialog
reproduction was not manually tested on macOS.

## Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content adheres to Zed's UI standards
([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
and
[icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md)
guidelines)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

---

Release Notes:

- Fixed Python toolchain discovery prompting installation of Apple
Command Line Tools when using a separately managed Python installation.
sergiooroman pushed a commit to sergiooroman/zed that referenced this pull request Sep 8, 2026
@cedws
languages: Avoid probing unresolved macOS Python shim (zed-industries…
9c8962e 
…#62534)

# Objective

Fixes zed-industries#62529.

Prevent Python toolchain discovery from executing Apple's
`/usr/bin/python3` Command Line Tools shim when no active developer
Python exists. Executing that unresolved shim causes macOS to repeatedly
prompt users to install the Command Line Tools, even when Python is
managed through Nix, uv, or pyenv.

## Solution

Update Python Environment Tools (PET) to `bb8e046`, which includes
microsoft/python-environment-tools#506. That upstream change resolves
active Xcode and Command Line Tools Python executables from filesystem
state and skips unresolved macOS system Python shims before generic
process probing.

Adapt Zed to the updated PET API by:

- displaying the newly supported Hatch environment kind
- passing no refresh identifier when running in-process environment
discovery

## Testing

- `cargo check -p languages --locked`
- PET unit tests covering unresolved macOS system Python shims
- The Zed compilation check was run on Linux; the original dialog
reproduction was not manually tested on macOS.

## Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content adheres to Zed's UI standards
([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
and
[icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md)
guidelines)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

---

Release Notes:

- Fixed Python toolchain discovery prompting installation of Apple
Command Line Tools when using a separately managed Python installation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osiewicz osiewicz osiewicz approved these changes

Assignees

No one assigned

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PET always probes /usr/bin/python3, forcing CLT install on macOS

3 participants

@cedws @osiewicz @SomeoneToIgnore