Skip to content

gpui: Add debug assertion to Window::on_action and make docs consistent - #41202

Merged
mikayla-maki merged 5 commits into
zed-industries:mainfrom
kognise:window-on-action-and-docs
Nov 6, 2025
Merged

mikayla-maki merged 5 commits into
zed-industries:mainfrom
kognise:window-on-action-and-docs

Conversation

@kognise

@kognise kognise commented Oct 26, 2025 •

Copy link
Copy Markdown
Contributor

Improves formatting consistency across various docs, fixes some typos, and adds a missing debug_assert_paint to Window::on_action and Window::on_action_when.

Release Notes:

  • N/A

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Oct 26, 2025
Comment thread crates/gpui/src/window.rs Outdated
@kognise
kognise requested a review from mikayla-maki November 1, 2025 17:54

@mikayla-maki mikayla-maki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mikayla-maki
mikayla-maki enabled auto-merge (squash) November 6, 2025 01:45
@mikayla-maki
mikayla-maki merged commit 2733216 into zed-industries:main Nov 6, 2025
37 of 39 checks passed
maxbrunsfeld pushed a commit that referenced this pull request Nov 6, 2025
…nt (#41202)

Improves formatting consistency across various docs, fixes some typos,
and adds a missing `debug_assert_paint` to `Window::on_action` and
`Window::on_action_when`.

Release Notes:

- N/A
maxbrunsfeld pushed a commit that referenced this pull request Nov 6, 2025
…nt (#41202)

Improves formatting consistency across various docs, fixes some typos,
and adds a missing `debug_assert_paint` to `Window::on_action` and
`Window::on_action_when`.

Release Notes:

- N/A
tomatitito pushed a commit to tomatitito/zed that referenced this pull request Nov 7, 2025
…nt (zed-industries#41202)

Improves formatting consistency across various docs, fixes some typos,
and adds a missing `debug_assert_paint` to `Window::on_action` and
`Window::on_action_when`.

Release Notes:

- N/A
11happy pushed a commit to 11happy/zed that referenced this pull request Dec 1, 2025
…nt (zed-industries#41202)

Improves formatting consistency across various docs, fixes some typos,
and adds a missing `debug_assert_paint` to `Window::on_action` and
`Window::on_action_when`.

Release Notes:

- N/A
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…nt (zed-industries#41202)

Improves formatting consistency across various docs, fixes some typos,
and adds a missing `debug_assert_paint` to `Window::on_action` and
`Window::on_action_when`.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants