Do not rely on drop() to perform final accumulation step - #83
Open
ebfull wants to merge 1 commit into
Open
Conversation
daira
approved these changes
Aug 14, 2018
daira
left a comment
daira
left a comment
Contributor
There was a problem hiding this comment.
utACK. Existing tests should cover.
stefandeml
pushed a commit
to stefandeml/sapling-crypto
that referenced
this pull request
Jul 5, 2019
feat(example): print number of constraints on bench
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MultiEqAPI relies ondrop, which is not guaranteed to run. By wrapping the logic in a closure we ensure the final accumulation step must be performed to proceed with execution.