prune old string dtype class#3973
Merged
Merged
Conversation
github-actions
Bot
added
the
needs release notes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3973 +/- ##
==========================================
+ Coverage 93.43% 93.49% +0.05%
==========================================
Files 88 88
Lines 11874 11861 -13
==========================================
- Hits 11095 11089 -6
+ Misses 779 772 -7
🚀 New features to boost your workflow:
|
github-actions
Bot
removed
the
needs release notes
…une-old-string-dtype
… into prune-old-string-dtype
d-v-b
commented
May 22, 2026
| def to_native_dtype(self) -> np.dtypes.ObjectDType: | ||
| """ | ||
| Create a NumPy object dtype from this VariableLengthUTF8 ZDType. | ||
| class UnknownObjectCodecDtype(VariableLengthUTF8): |
Contributor
Author
There was a problem hiding this comment.
this test didn't actually depend on the codec using the "object" codec. it just depends on having an unknown object codec id
maxrjones
approved these changes
May 22, 2026
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we supported NumPy versions < 2, we had to implement the variable-length string dtype on top of the numpy "object" dtype. For NumPy versions > 2, we use the
StringDType.Since we no longer support numpy < 2, we can remove the variable-length dtype class that used the "object" dtype. that's this PR.