Fix exception handling on anitopy episode number parsing#844
Open
Neelo16 wants to merge 1 commit into
Open
Conversation
Neelo16
force-pushed
the
fix-anitopy-episode-numbers
branch
from
a4e8032 to
208b62a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to close #843. I opted to use the same logic that is already being used in
getEpisodeNumbers, which is using Decimal to parse the episode number, and then trying to convert that into an int, while also gracefully handling ArithmeticErrors. This fix is what I used for the "Expected Behavior" in the issue, so I can confirm that it works for at least my problematic example.