fix(auth): signed-in session always has a YouVersion user id - #134
Closed
cameronapak wants to merge 3 commits into
Closed
fix(auth): signed-in session always has a YouVersion user id#134cameronapak wants to merge 3 commits into
cameronapak wants to merge 3 commits into
Conversation
Enforce that authenticated sessions always carry a string user id: - Tighten isAuthenticated to require token and userInfo.id - getAccessToken status ok returns userId: string; missing id is signed-out - Reject sign-in and bootstrap commits without an id; clear orphan tokens - Persist id_token and repair cold start from stored sub when cache lacks id - Require id in cachedUserInfoSchema and YVUserInfo type Co-authored-by: Cameron Pak <cameronandrewpak@gmail.com>
…riant Co-authored-by: Cameron Pak <cameronandrewpak@gmail.com>
Co-authored-by: Cameron Pak <cameronandrewpak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A signed-in session always has a YouVersion user id (
userInfo.idis a non-empty string). This is tightening a potential insecurity in our auth-layer.