Skip to content

android: remove hard code 4kb page size for arm devices#11078

Draft
tasunnn wants to merge 1 commit into
youtube:mainfrom
tasunnn:dynamic-page-size-query-android
Draft

android: remove hard code 4kb page size for arm devices#11078
tasunnn wants to merge 1 commit into
youtube:mainfrom
tasunnn:dynamic-page-size-query-android

Conversation

@tasunnn

@tasunnn tasunnn commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Bug: 527944046

@tasunnn tasunnn requested a review from a team as a code owner June 25, 2026 22:30
@tasunnn tasunnn requested a review from fayev-g June 25, 2026 22:30
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


android: Enable dynamic page size for all Android CPUs

Enable dynamic page size lookup for all Android architectures in the
partition allocator. 32-bit Android was previously hardcoded to a 4KB
page size.

32-bit Android userspace may run on 64-bit Android kernels configured
with 16KB or 64KB pages. Hardcoding 4KB in these hybrid GKI
environments causes SIGTRAP crashes when decommitting memory with
MAP_FIXED. Dynamic lookup prevents these crashes and improves
compatibility with modern TV hardware.

Bug: 527944046

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates page_allocator_constants.h to enable dynamic page size lookup for all Android architectures, including 32-bit userspace. This change prevents SIGTRAP crashes when decommitting memory with MAP_FIXED on hybrid GKI TV environments configured with 16KB/64KB pages. There are no review comments, and I have no feedback to provide.

@tasunnn tasunnn marked this pull request as draft June 25, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant