Repository navigation
Conversation
ygao-g
force-pushed
the
ocispec-nofile-limit
branch
from
October 1, 2026 17:22
869ad8f to
c5454cf
Compare
The OCI spec builder hard-coded RLIMIT_NOFILE at 1024 for every actor container. Add a new atelet flag to set the soft and hard limit for actor containers node-wide, with 1024 as default.
ygao-g
force-pushed
the
ocispec-nofile-limit
branch
from
October 1, 2026 18:54
c5454cf to
16c9cc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an atelet flag,
--actor-nofile-limit, that sets the soft and hardRLIMIT_NOFILEin the OCI spec written for every actor container on the node. The default stays 1024, so the spec is unchanged unless the flag is set, and atelet refuses to start with a value outside[1, 1<<20].Motivation: a load generator running as an actor hit the hard-coded 1024 descriptor ceiling during actor-egress benchmarking. The patched atelet in that benchmark is this commit on an older base; with the flag at 65536 a probe actor opened 1600 sockets.
Operational caveat: runsc rejects a restore whose rlimits differ from the checkpoint's, so changing the flag on a node makes its existing snapshots unrestorable until they are recut. Whether this should instead be a per-template field is the open question for upstream.
Base is pinned at upstream
b5ad4b35so the diff is exactly the one commit under review. Intended for upstream after review here.16c9cc4b🤖 This PR was developed with AI assistance. I have reviewed and tested all changes.