web-ui: an email draft folds its To and Subject away - #979
Closed
evebouf wants to merge 1 commit into
Closed
Conversation
Replying from the inbox almost never means changing who it goes to or what it is called: the agent fills both from the thread it is answering. Yet the three fields sat above the body on every email item, so the first thing a reader met was routing they were not going to touch, and the draft itself started a third of the way down. Fold them into a details, shut by default, behind a line that still names the recipient and the subject. Nothing is hidden, only unstacked, and the one case that needs an edit is a click away. A details element keeps its own open state, so a redraw mid-edit does not close it, and no state has to be tracked to do that. The default subject was computed inline in the input's value binding, where the summary could not reach it. It moves to draftSubject() and both callers read the same string. Slack drafts are unchanged; they never had these fields. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Author
|
Folded into #976 — this belongs with the rest of the small UI fixes on that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On an email inbox item, the draft's To, Cc and Subject fields sat open above the body. You almost never edit them — the agent fills them from the thread — so they pushed the actual draft down the page for nothing.
<details>, collapsed by default<details>keeps its own open state, so a redraw mid-edit won't snap it shut, and no state has to be trackedRe: …subject out of the input's value binding intodraftSubject(), so the summary and the field can't drift apartSlack drafts are untouched — they never had these fields.
web-ui 939/939, typecheck and prettier clean.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.