Debug Crystal tests failing in GitHub Actions - #7
Merged
yb66 merged 3 commits intoNov 23, 2025
Merged
Conversation
The shell_spec.sh test script was calling 'ruby exe/path_helper' on line 167, which prevented the Crystal implementation tests from working. The Crystal executable is a compiled binary and cannot be run with the Ruby interpreter. Changed to use "$PWD/exe/path_helper" directly, which works for both: - Ruby implementation (via shebang #!/usr/bin/env ruby) - Crystal implementation (as a compiled binary) This makes the test script language-agnostic and fixes Crystal test failures in GitHub Actions.
The Crystal implementation was outputting one trailing newline after the env var in debug mode, while the Ruby version outputs two newlines. Changed from: print env_var puts "\n" To: print env_var << "\n\n" This matches the Ruby implementation (exe/path_helper:378) and fixes the debug_path_spec and pkg_config_spec test failures in GH Actions.
Crystal doesn't support the << operator for string concatenation. Changed from: print env_var << "\n\n" To: print env_var + "\n\n" This fixes the compilation error in GitHub Actions.
yb66
deleted the
claude/debug-crystal-tests-gh-actions-01X7i41vfL8ZyzNJWVGTpyqA
branch
November 23, 2025 05:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell_spec.sh test script was calling 'ruby exe/path_helper' on line 167, which prevented the Crystal implementation tests from working. The Crystal executable is a compiled binary and cannot be run with the Ruby interpreter.
Changed to use "$PWD/exe/path_helper" directly, which works for both:
This makes the test script language-agnostic and fixes Crystal test failures in GitHub Actions.