fix: add missing simple and envelope-json convention YAML resources#44
Merged
Conversation
Two built-in convention YAML files were missing from the classpath, causing YangProtoConventionTest to fail with IllegalArgumentException. https://claude.ai/code/session_019NY8Mv6p6rb8HSB9pJKugn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YangProtoConventionTest中两个测试因找不到 classpath 资源文件而失败simple-convention.yaml:顺序字段编号、原始类型、无 wrapper 的结构化约定envelope-json-convention.yaml:envelope 模式、JSON 内部格式的约定Test plan
YangProtoConventionTest#loadBuiltinClasspathYaml_simple本地验证通过YangProtoConventionTest#loadBuiltinClasspathYaml_envelope本地验证通过yangkit-data-proto-codec模块完整测试套件通过https://claude.ai/code/session_019NY8Mv6p6rb8HSB9pJKugn
Generated by Claude Code