Fix remaining derive hygiene edge cases - #138
Open
ya7010 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enumeratewarnings from named and tuple enum fieldsRed-to-green verification
Before the implementation changes, the new tests reproduced all four problems:
min_lengthvalidationOk(())instead of the custom validation errorerror_paramsstaticThe same tests pass after the fixes.
Verification
cargo nextest run(331 passed)cargo nextest run --all-features(342 passed)cargo test --all-featurescargo test --no-default-featurescargo clippy -- -D warningscargo fmt --all -- --checkgit diff --check