Conversation
|
|
||
| from ._any import encode_any | ||
| from ._doc import Doc | ||
| from ._pycrdt import decode_any as _decode_any |
Collaborator
There was a problem hiding this comment.
Why not the following?
Suggested change
| from ._pycrdt import decode_any as _decode_any | |
| from ._any import decode_any |
| } | ||
| // An `int` that doesn't fit in 64 bits has no `Any` representation; callers that need to | ||
| // report that precisely use `py_to_any_strict`, everyone else treats it as unsupported. | ||
| py_to_int_any(value).unwrap_or(Any::Undefined) |
Collaborator
There was a problem hiding this comment.
Is this a breaking change?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @davidbrochart,
I'm currently working on a project that requires reading lib0-encoded content from python. Could we export encode_any / decode_any from pycrdt? I'd appreciate a review and if you could make a new release once you are done.
Thanks!