templates/go: disambiguate fields from digit-prefixed SQL columns#434
Open
rosensama wants to merge 1 commit into
Open
templates/go: disambiguate fields from digit-prefixed SQL columns#434rosensama wants to merge 1 commit into
rosensama wants to merge 1 commit into
Conversation
snaker.ForceCamelIdentifier strips leading digits, so columns "1X", "2X",
"3X" all collapse to a single Go field named "X" — producing structs with
duplicate fields that won't compile.
When a column name starts with a digit, append "_<sanitized original>" to
the generated GoName ("1X" -> "X_1X"). Sanitization matches the current
snaker identifier rune class (Unicode letters, digits, underscore), which
in turn matches the Go language spec.
Fixes xo#433.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1X,2X,3Xall collapse to a single Go fieldXbecausesnaker.ForceCamelIdentifierstrips leading digits — generating structs with duplicate fields that fail to compile._<sanitized original>to the generatedGoName(e.g.1X→X_1X,2X→X_2X).Fixes #433.
Tested against an MSSQL repro of the issue with a local build.
🤖 Generated with Claude Code