Conversation
Use brew when present; otherwise fail with install hints so Linux/other nix hosts are not broken by unconditional brew calls. Closes xmtp#512
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./dev/upcalledbrewunconditionally and broke Linux/other hosts. Use brew when present; otherwise print clear install hints.Testing
bash -n dev/upCloses #512
Note
Stop assuming Homebrew is available in
dev/upAdds a reusable
ensure_cmdhelper to dev/up that checks whether a required command exists before attempting installation. If Homebrew is available it installs the specified package; otherwise it prints an error with OS-specific hints to stderr and exits with status 1. Behavioral Change: on non-macOS or Homebrew-free environments, missing tools (chronic,golangci-lint,shellcheck,protoc,mockery) now cause the script to abort rather than silently proceed.Macroscope summarized 4455bea.