insipx/db integrity 2 corrupt classification

[insipx]

Stacked on #4029. A corrupted-but-correctly-keyed encrypted DB previously failed client-open as SqlCipherKeyIncorrect ("PRAGMA key or salt has incorrect value"), indistinguishable from a wrong key. Corruption-shaped validate failures now surface as the new non-retryable PlatformStorageError::DatabaseCorrupt; wrong-key behavior is unchanged, and the comment documents why the two remain ambiguous in general under plaintext headers. Includes a deterministic corruption regression test (truncate + byte-flip, 10/10) and a retryability assertion.

🤖 Generated with Claude Code

https://claude.ai/code/session_01V1AXHNsnQmHW174i5rRUEb

Note

Add DatabaseCorrupt variant to PlatformStorageError and detect corruption in EncryptedConnection::validate

• Adds DatabaseCorrupt(String) to the PlatformStorageError enum and returns false from is_retryable() for this variant, classifying corruption as non-retryable.
• Updates EncryptedConnection::validate in sqlcipher_connection.rs to inspect the PRAGMA/key validation error message; if it contains "malformed" or "corrupt" the error surfaces as DatabaseCorrupt, otherwise it remains SqlCipherKeyIncorrect.
• Adds tests covering both the non-retryable classification and the corruption-vs-wrong-key distinction.
• Behavioral Change: callers that previously saw SqlCipherKeyIncorrect for a corrupt database will now see DatabaseCorrupt; retry logic will no longer attempt retries on corruption errors.

^{Macroscope summarized 9859ebb.}

[claude]

Claude finished @insipx's task —— View job

---

Code Review (2026-08-27 15:47 UTC)

This PR effectively distinguishes database corruption from incorrect encryption keys. The implementation is clean and well-tested. A few observations:

Error Message Inspection (sqlcipher_connection.rs:274)

The corruption detection relies on string matching (contains("malformed") || contains("corrupt")). While pragmatic, this is fragile to SQLite/SQLCipher message changes. The comment on line 277-279 correctly acknowledges the inherent ambiguity under plaintext headers, documenting why both errors remain non-retryable.

Minor concern: The to_lowercase() conversion on line 273 could theoretically cause issues if SQLCipher uses locale-specific casing (unlikely, but worth noting). ASCII-specific matching might be more robust.

Test Coverage

The test at line 477 (corrupt_db_reports_corrupt_not_wrong_key) is excellent—deterministic corruption via truncate + byte-flip. This addresses the 1 missing line in codecov (likely a defensive error branch).

Retryability Classification

The is_retryable() implementation (native.rs:245) correctly marks DatabaseCorrupt as non-retryable. The test at line 1004 verifies this.

Performance & Security

No concerns. This is an error path change with no runtime overhead on the happy path.

Minor Nit

sqlcipher_connection.rs:272: The error log includes the full error from batch_execute. If the error message ever contained sensitive data (unlikely for a PRAGMA failure, but worth considering), this could leak into logs.

---

Summary: The implementation is sound. The string-matching detection is pragmatic given SQLite's error reporting. The comprehensive regression test and retryability assertion provide good coverage. No blocking issues.

---

[codecov]

Codecov Report

❌ Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (insipx/db-integrity-1-core@3b41bb0). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...pted_store/database/native/sqlcipher_connection.rs	97.50%	1 Missing ⚠️

Additional details and impacted files

@@                      Coverage Diff                      @@
##             insipx/db-integrity-1-core    #4030   +/-   ##
=============================================================
  Coverage                              ?   85.96%           
=============================================================
  Files                                 ?      421           
  Lines                                 ?    68854           
  Branches                              ?        0           
=============================================================
  Hits                                  ?    59193           
  Misses                                ?     9661           
  Partials                              ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[macroscopeapp]

Approvability

Verdict: Approved at 991b609

Macroscope's review found this PR approvable — This is a small, self-contained fix that distinguishes corrupted encrypted databases from incorrect keys while preserving existing retry behavior. It changes only an error path, adds targeted regression coverage, and is fully within the author’s owned storage code.

No code changes detected at 9859ebb. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}