feat(node-sdk): expose dbIntegrityCheck and checkDatabaseIntegrity

[insipx]

Top of the DB-integrity-check stack (on #4032). Re-exports the node bindings' integrity API through @xmtp/node-sdk: Client.dbIntegrityCheck(level?) and the package-level checkDatabaseIntegrity / IntegrityCheckLevel / IntegrityCheckOutcome. Typecheck + eslint clean.

See #4029 for the feature overview and testing summary.

🤖 Generated with Claude Code

https://claude.ai/code/session_01V1AXHNsnQmHW174i5rRUEb

Note

Expose dbIntegrityCheck on Client and re-export checkDatabaseIntegrity from Node SDK index

• Adds async method Client.dbIntegrityCheck(level?) in Client.ts that delegates to the underlying NodeClient instance.
• Re-exports checkDatabaseIntegrity, IntegrityCheckLevel, and IntegrityCheckOutcome from @xmtp/node-bindings in index.ts.
• Behavioral Change: Client.dbIntegrityCheck throws ClientNotInitializedError if called before the client is initialized.

^{Macroscope summarized f4a43d0.}

[claude]

Claude finished @insipx's task —— View job

---

PR Review - 2026-08-27 15:47 UTC

• Read changed files
• Analyze code quality and implementation
• Check for test coverage
• Provide feedback

Summary

This PR cleanly exposes the database integrity check functionality in the Node SDK layer. The implementation is straightforward and follows existing patterns in the codebase.

Code Quality: ✅ Good

Client.ts (lines 325-342)

• The dbIntegrityCheck method follows the established pattern for other client methods
• Properly throws ClientNotInitializedError when client is uninitialized (consistent with other methods)
• JSDoc is clear and accurate
• The parameter is correctly typed as optional with IntegrityCheckLevel type

index.ts (lines 79, 118)

• Clean re-exports of checkDatabaseIntegrity, IntegrityCheckLevel, and IntegrityCheckOutcome
• Alphabetically ordered within export groups (maintaining existing convention)

Test Coverage: ⚠️ Missing

Observation: While the underlying @xmtp/node-bindings package has comprehensive integrity tests (bindings/node/test/Integrity.test.ts), there are no tests at the @xmtp/node-sdk layer for:

• Client.dbIntegrityCheck() method
• Re-exported checkDatabaseIntegrity function

Recommendation: Add tests in sdks/js/node-sdk/test/Client.test.ts to verify:

1. client.dbIntegrityCheck() works on a healthy database
2. client.dbIntegrityCheck() throws ClientNotInitializedError before init
3. Optional: Basic smoke test for the re-exported checkDatabaseIntegrity to ensure the SDK export works

This would ensure the SDK layer's API surface is tested, even though the underlying functionality is already well-tested.

Other Notes

• No performance concerns (read-only operation)
• No security concerns (security issues in lower layers were already addressed)
• Type definitions are properly imported and re-exported
• Breaking changes: None (purely additive API)

---

[macroscopeapp]

Approvability

Verdict: Approved at 7bfc39c

Macroscope's review found this PR approvable — This is a small, isolated Node SDK API-surface addition that forwards to already-existing integrity-check bindings only when explicitly invoked. Existing behavior, stored data, and production configuration remain unchanged.

No code changes detected at f4a43d0. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[codecov]

Codecov Report

❌ Patch coverage is 91.87935% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.91%. Comparing base (da3e3c5) to head (e3cd796).
⚠️ Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/xmtp_db/src/encrypted_store/integrity.rs	93.75%	21 Missing ⚠️
crates/xmtp_db/src/encrypted_store/mod.rs	0.00%	7 Missing ⚠️
...tes/xmtp_db/src/encrypted_store/database/native.rs	85.71%	3 Missing ⚠️
crates/xmtp_mls/src/context.rs	25.00%	3 Missing ⚠️
...pted_store/database/native/sqlcipher_connection.rs	97.82%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4028      +/-   ##
==========================================
- Coverage   86.00%   85.91%   -0.09%     
==========================================
  Files         417      420       +3     
  Lines       68165    68829     +664     
==========================================
+ Hits        58622    59137     +515     
- Misses       9543     9692     +149     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.