Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flaky Android group message stream test by ignoring empty-body events before asserting on streamed text messages.
The stream can emit non-text/system events with an empty body, so assuming the first emitted item is the
"hi"text message can cause the assertion to fail nondeterministically.This keeps the change scoped to the test and avoids adding timing-based sleeps.
Testing
git diff --checkpasses.Related to #3941.
Note
Filter empty events from group message stream in Android tests
Applies a
filter { it.body.isNotEmpty() }to thegroup.streamMessages()flow in GroupTest.kt so test assertions only operate on non-empty messages. This prevents spurious failures caused by empty events emitted before the actual message arrives.Macroscope summarized 3246147.