Fix race condition in tokenizer loading threading issues - #2
Open
xiaogecai wants to merge 1 commit into
Open
Conversation
xiaogecai
commented
Jul 24, 2026
xiaogecai
left a comment
xiaogecai
left a comment
Owner
Author
There was a problem hiding this comment.
Technical review: The OnceLock + mutex approach provides robust thread safety for concurrent access. DOWNLOAD_MUTEX ensures only one thread initializes the tokenizer at a time, preventing race conditions. The offline loading API from #1 is properly integrated.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Thread-safe fix for race condition in tokenizer loading using OnceLock and Mutex.
Changes
Testing
Verified against race condition scenarios from #6 and #1.
Closes #1