Repository navigation
Conversation
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review — chore: remove deprecated things
Clean deletion-only PR (3058 lines, 24 files). I verified the removal is safe at the source level: no remaining Go source imports any deleted package (xtool/clang/{ast,check,pathutil,preprocessor,_types}, chore/{clangpp,llpyg,_deprecated}, _xtool/*), the surviving xtool/clang/clang.go is self-contained, no runtime/build hot-path code is touched, and no secrets are involved. The link-arg safety control (CheckLinkArgs) still lives on the production path (internal/clang/clang.go, xtool/clang/clang.go).
The deletions do leave several dangling references outside the diff that should be cleaned up in this same PR. The diff only touches deleted files, so these can't be posted inline — listed below by priority.
Must fix — breaks CI
.github/workflows/llgo.yml:415-423— the_xtool build testsstep runscd _xtool+llgo build -v ./...._xtool/is deleted, socd _xtoolfails and this job breaks on every non-Windows / Windows-amd64 run. Remove this step (and its_xtoolcomment block) as part of the deletion.
Should fix — broken install path / docs
doc/_readme/scripts/install_full.sh:5,7,8— documented bootstrap doescd _xtoolthenllgo install ./... # compile pydump;_xtool/no longer exists, so the install guide now fails. Fix the script and re-runembedmeso the README block stays in sync.README.md:559-563— embedme-generated copy of the install block above; corrected automatically once the source script is fixed and embedme re-run.README.md:541—[pydump](_xtool/pydump)is now a dead relative link (thedoc-link-checker/ lychee job will flag it). Remove the bullet.README.md:543—[llpyg](chore/llpyg)dead relative link; its description also references the removedpydump. Remove or rewrite.
Nice to fix — stale references
README.md:246— "import Python libraries intollgothroughllpyg" points at removed tooling.doc/LLGo-Bindings.md:52,81— referencellpyg/pydumpas the binding-generation path.CLAUDE.md:16— listsllpygamongchore/dev tools (llgen,ssadumpstill exist; onlyllpygis stale).THIRD_PARTY_NOTICES.md:16— attributes TinyGo-derived code to the deletedchore/_deprecated/ar/ar.go; drop this bullet so the attribution isn't dangling. (The survivingxtool/ar/is separately BlakeSmith/MIT-attributed at line 51 and stays accurate.)
Checked — no change required
.github/scripts/test_classify_benchmark_changes.py:44andclassify_benchmark_changes.py:120— the_xtool/...values are synthetic path-classification inputs/rules, not filesystem reads; tests still pass. Harmless; optionally tidy if you drop the_xtoolclassifier rule.
Net: the code removal itself is safe. The one actionable blocker is the CI step at llgo.yml:415-423; the rest are install-script/README/doc cleanups worth doing in the same PR.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
LLGo WebAssembly build benchmarks
WebAssembly output sizes
LLGo WebAssembly build measurements
Compared with |
LLGo baseline benchmarks
Program measurements
Core language and compiler benchmarks
Timer runtime benchmarks
Compared with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.