Repository navigation
Conversation
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code review summary
Thorough, well-engineered PR. It adds a Dependabot CI cleanup system: a no-permission pull_request_target signal workflow (dependabot-pr-closed.yml), a trusted workflow_run consumer (dependabot-ci-cleanup.yml) that checks out only base-branch script code, and dependabot_ci.py which cancels obsolete Dependabot runs via the REST API.
Strengths: the pull_request_target/workflow_run privilege-escalation surface is handled correctly — the privileged actions: write job runs only trusted base-branch code (ref: ${{ github.sha }}, persist-credentials: false, sparse-checkout), the signal workflow is inert (permissions: {}, no checkout), and bot_pull() re-validates Dependabot identity against live PR state before every cancellation. The TOCTOU races (merge/reopen/head-change while listing) are each handled and individually tested. All 28 unit tests pass locally. No exploitable security issue was found.
The findings below are low-severity robustness / maintainability / informational notes — none are blocking.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cpunion
changed the title
cpunion
force-pushed
the
codex/dependabot-ci-cleanup
branch
3 times, most recently
from
October 12, 2026 13:55
058c2bc to
4786a76
Compare
cpunion
changed the title
LLGo WebAssembly build benchmarks
WebAssembly output sizes
LLGo WebAssembly build measurements
Compared with |
LLGo baseline benchmarks
Program measurements
Core language and compiler benchmarks
Timer runtime benchmarks
Compared with |
cpunion
force-pushed
the
codex/dependabot-ci-cleanup
branch
from
October 17, 2026 06:22
4786a76 to
7599118
Compare
cpunion
force-pushed
the
codex/dependabot-ci-cleanup
branch
from
October 18, 2026 03:44
7599118 to
4f998cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancel existing PR CI runs when a PR closes, including merges; main CI continues independently on push.
pull_requestworkflows: 53 job definitions and 115 matrix-expanded job slots, including conditionally skipped jobs. Workflow-level cancellation includes the sharedci-prepare.ymljobs and the latest SDK 27, Linux distribution, and ARM64 jobs.always() && !cancelled()..ymland.yamlworkflows.Scope: cancels existing
pull_requestworkflow runs; later reruns and close/reopen races are not handled. The separate benchmark publication workflow usesworkflow_runand only starts its artifact processing after a successful source run. Takes effect after merge to main.Validation: 58 workflow/policy/script tests passed;
actionlint -shellcheck=''andgit diff --checkpassed. Mutation checks confirmed that unconditionalalways()in a matrix or reusable job and a mismatched PR-only concurrency group are rejected. Previous fork Actions validation confirmed cancellation and isolation from other PR/main groups. Rebased onto upstream/main at 0a2ebb8. This includes 0c417c8, which addresses the previously failing Wasm workers job by giving collection-heavy language tests a separate 480s test / 600s outer budget and isolating the goroutine-count assertion. The upstream fix passed the Wasm workers job in #2843. Hosted CI for this updated PR revision is pending.