interpreter: (arith) Implement run_select for arith.select - #6352
Open
jumerckx wants to merge 2 commits into
Open
interpreter: (arith) Implement run_select for arith.select#6352jumerckx wants to merge 2 commits into
run_select for arith.select#6352jumerckx wants to merge 2 commits into
Conversation
ed741
reviewed
Aug 10, 2026
Comment on lines
+268
to
+269
| assert len(args) == 3 | ||
| return (args[1] if args[0] else args[2],) |
Collaborator
There was a problem hiding this comment.
This doesn't handle the vector condition case, but i don't know if the rest of the stuff in the airth interpreter does either.
superlopuh
approved these changes
Aug 10, 2026
alexarice
approved these changes
Aug 16, 2026
alexarice
left a comment
alexarice
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me though I'm not an expert on the interpreter
| self, interpreter: Interpreter, op: arith.SelectOp, args: PythonValues | ||
| ): | ||
| assert len(args) == 3 | ||
| cond, lhs, rhs = args |
Collaborator
There was a problem hiding this comment.
Nit: what's the error you would get here if you remove the assert?
| f"arith.select shape mismatch: {shaped_cond.shape}, " | ||
| f"{shaped_lhs.shape}, {shaped_rhs.shape}", | ||
| ) | ||
| data: list[Any] = [ |
Collaborator
There was a problem hiding this comment.
why a list here instead of tuple?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6352 +/- ##
==========================================
+ Coverage 86.90% 86.93% +0.02%
==========================================
Files 437 437
Lines 65823 65840 +17
Branches 7485 7489 +4
==========================================
+ Hits 57206 57238 +32
+ Misses 7042 7028 -14
+ Partials 1575 1574 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.