CI: enable Ruff RUF005 - #6259
Open
iamdhrv wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6259 +/- ##
==========================================
+ Coverage 87.07% 87.09% +0.01%
==========================================
Files 433 433
Lines 65255 65313 +58
Branches 7465 7465
==========================================
+ Hits 56822 56882 +60
+ Misses 6864 6862 -2
Partials 1569 1569 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
superlopuh
reviewed
Jul 15, 2026
superlopuh
reviewed
Jul 15, 2026
alexarice
approved these changes
Jul 16, 2026
alexarice
left a comment
alexarice
left a comment
Collaborator
There was a problem hiding this comment.
There's a few more places we could use tuples instead of lists, but that feels like work for a different PR to me
Member
|
@iamdhrv, when will you have time to resolve the merge conflicts and address my comments? |
iamdhrv
force-pushed
the
ci/5927-enable-ruf005
branch
from
July 29, 2026 16:09
01fe9b2 to
6d10875
Compare
Signed-off-by: Dhruv Maniya <dhruvmaniya1998@gmail.com>
superlopuh
reviewed
Jul 30, 2026
Collaborator
|
This is just waiting for one tiny change right? |
Member
|
Yeah, I just committed my suggestion, will merge when CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Progresses #5927 (RUF005 slice).
Validation
uv run ruff check .uv run ruff format --check .(729 files)uv run pyright(0 errors)make pytest(5050 passed, 1 skipped)make filecheck(494 passed, 110 unsupported because external MLIR tools are not configured)