chore: add Dependabot config for actions, uv, and docker#36
Conversation
Add weekly Dependabot version updates for GitHub Actions, the two uv-based Python tools (scripts/git-review-rebase and scripts/kabi), and the riscv Docker base images, each with a 7-day cooldown. Driver submodules are intentionally excluded; they are handled by the existing update-driver-submodules workflow. Signed-off-by: Bruno Verachten <gounthar@gmail.com>
casasnovas
left a comment
There was a problem hiding this comment.
Thanks for adding this! I can't comment for Baptiste's docker eco-system if he needs version pined for a specific reason, but lgtm for the two python scripts.
There's an issue flagged by by izimor which I'll let you fix.
The update-driver-submodules workflow intentionally persists the GITHUB_TOKEN on checkout so its "Commit and open PR" step can `git push --force origin`. It uploads no artifacts, so the artipacked credential-leak vector (token exposure via uploaded artifacts) does not apply here. Add .github/zizmor.yml scoping the artipacked ignore to that one file, so zizmor passes without weakening the audit for the rest of the workflows. Signed-off-by: Bruno Verachten <gounthar@gmail.com>
|
Thanks for the review @casasnovas, and good point on the docker side. I left Baptiste's images alone on purpose so I wouldn't step on the build-arg / pinned-tag setup, but happy to revisit if he wants them tracked. Pushed a fix for the zizmor one (4b30ed2). It was the If you'd rather harden it for real ( |
Oh apologies I missed this issue was predating your branch, it's actually my fault and the correct fix is in #35, looks like I inadvertently pushed to main the broken code. There is no need to ignore the warning from zizmor as we can simply make things explicit. You can either revert your branch to prior state and wait for PR 35 to be merged, or after Baptiste's input I can simply merge your code bypassing the zizmor check since it has nothing to do with your PR. |
…ules" The artipacked finding is fixed properly upstream in xcp-ng#35, which sets persist-credentials explicitly on the checkout (what actually silences the audit). With that fix the scoped ignore is redundant and would mask the audit on this workflow going forward, so drop it and let xcp-ng#35 be the fix. This branch is back to just the Dependabot config. This reverts commit 4b30ed2. Signed-off-by: Bruno Verachten <gounthar@gmail.com>
|
No worries, and thanks for digging into it. Makes sense — setting I've reverted my |
Sorry for the late reply, I don't think the docker needs a specific version at all. Igtm as well, thanks for adding this @gounthar ! It looks like you need to add |
|
Thanks Baptiste, appreciate the look. One wrinkle though: the zizmor finding isn't actually coming from this PR. #36 only adds |
|
I think the best is to wait #35 to be merged then do a rebase on that to make sure all is green. |
Right now dependency bumps in this repo get noticed by hand, if at all. This adds a
.github/dependabot.ymlso they show up as PRs instead. Same approach already running inxcp-ng-tests, so nothing exotic here.Ecosystems, all weekly with a 7-day cooldown:
github-actions(/): bumps the SHA-pinned actions in the workflows, keeping the pin and the version comment.uv: the twouv.locktools,scripts/git-review-rebaseandscripts/kabi.docker(/docker/riscv/trixie/image): in practice this only tracksdebian:trixie-slim. Thebaptleduc/xen-riscv64-kerneland the gitlab image come in through a build-arg or a pinned tag, so Dependabot leaves them alone.One thing I left out on purpose: the driver submodules. They already have
update-driver-submodules.yml, which tracksorigin/8.3and re-imports sources. Dependabot'sgitsubmoduleecosystem would just fight that, so I kept it clear of them.I validated this on my fork before opening here: Dependabot picked up the config and opened real
uvPRs with the cooldown applied.Happy to adjust the schedule, the cooldown, or drop an ecosystem if you'd rather start narrower.