Skip to content
Open

Apps #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
450 commits
Select commit Hold shift + click to select a range
9252a50
Refactor `runtime` for improved modularity and consistency:
Hadamcik Apr 25, 2026
34971b4
Ensure `write_runtime` locks are scoped for proper concurrency manage…
Hadamcik Apr 25, 2026
0fab96b
Replace `write_runtime` with `write_runtime_and_emit_changed` across …
Hadamcik Apr 25, 2026
e032225
Refactor bridge invocation logic:
Hadamcik Apr 25, 2026
64c245f
Refactor bridge communication and runtime state management:
Hadamcik Apr 25, 2026
7c1e20c
Add `state.rs` for managing pending bridge approvals and update bridg…
Hadamcik Apr 25, 2026
e5fc85b
Refactor bridge and runtime logic:
Hadamcik Apr 25, 2026
5bb9959
Refactor bridge module structure and capability handling:
Hadamcik Apr 25, 2026
9a06465
Introduce `BridgeState` for managing pending bridge approvals:
Hadamcik Apr 25, 2026
e0b0737
Modularize lifecycle install logic:
Hadamcik Apr 25, 2026
a84867b
Add tests and refactor install logic for `UrlInstallSource` and `ZipI…
Hadamcik Apr 26, 2026
5fee62b
Refactor: centralize `slugify_name` logic and simplify retired app te…
Hadamcik Apr 26, 2026
23121bb
Modularize lifecycle update logic:
Hadamcik Apr 26, 2026
e93ed03
Remove unused lifecycle modules and consolidate registry logic:
Hadamcik Apr 26, 2026
8184413
Refactor bridge methods and runtime logic:
Hadamcik Apr 26, 2026
083d6e4
Refactor approval request logic in bridge methods:
Hadamcik Apr 26, 2026
f113420
Remove redundant `normalize` module and consolidate capability logic:
Hadamcik Apr 26, 2026
4573b86
Modularize and streamline permission normalization and validation:
Hadamcik Apr 26, 2026
5bf406a
Refactor: replace `resolve_effective_granted_capabilities` with `get_…
Hadamcik Apr 26, 2026
c79b4d3
Refactor: replace `SageAppCapabilityFlags` with `SageAppFlags` and mo…
Hadamcik Apr 26, 2026
4dca3d3
Rename `policy.rs` to `tests.rs` in the `permissions` module for bett…
Hadamcik Apr 26, 2026
77387dd
Refactor: consolidate and enhance capabilities validation and normali…
Hadamcik Apr 26, 2026
40b19f2
Refactor: replace `get_and_validate_effective_granted_capabilities` w…
Hadamcik Apr 26, 2026
4bdff96
Refactor: restrict `CapabilityFlags` visibility and simplify imports
Hadamcik Apr 26, 2026
00c29a4
Refactor: modularize and enhance network permission validation and no…
Hadamcik Apr 26, 2026
47cf8d9
Refactor: standardize and enhance capability validation and normaliza…
Hadamcik Apr 26, 2026
2c32a92
Refactor: remove `clear_storage_taint` flag and related logic
Hadamcik Apr 26, 2026
07abb1b
Refactor: simplify and consolidate network permission validation and …
Hadamcik Apr 26, 2026
e41bfbb
Remove redundant and unused unit tests in `permissions/tests.rs`
Hadamcik Apr 26, 2026
134fd82
Remove redundant permission normalization and validation logic
Hadamcik Apr 27, 2026
f69fd44
Clippy fixes
Hadamcik Apr 27, 2026
81a66d0
Clippy fixes
Hadamcik Apr 27, 2026
40991fa
Introduce comprehensive Sage App types and manifest handling
Hadamcik Apr 27, 2026
e397582
Enhance network whitelist deserialization and manifest error reporting
Hadamcik Apr 27, 2026
cb71029
Clippy
Hadamcik Apr 27, 2026
d1907e9
Remove `types_legacy.rs` and associated unused tests
Hadamcik Apr 27, 2026
fa555d8
Encapsulation
Hadamcik Apr 28, 2026
ac5c589
Refactor: centralize `builtin_apps_root` logic and adjust system apps…
Hadamcik Apr 28, 2026
fad4cbf
Refactor: centralize app update logic with `fetch_pending_update`
Hadamcik Apr 28, 2026
a8e41d9
Refactor: centralize app icon logic with `AppIconContent` and `AppIco…
Hadamcik Apr 28, 2026
b45f31b
Simplify task-manager build output directory path in `vite.config.ts`
Hadamcik Apr 28, 2026
47dc52b
Clippy
Hadamcik Apr 28, 2026
66bf17a
Move capabilities
Hadamcik Apr 28, 2026
b0f6bbe
Invariants and fmt
Hadamcik Apr 28, 2026
cec9e12
Refactor: extract and centralize capability validation and building l…
Hadamcik Apr 28, 2026
ea6c0e2
Refactor: extract and reuse `split_required_optional_set` for whiteli…
Hadamcik Apr 28, 2026
dff4f8e
Refactor: restructure `invariants` module and centralize logic
Hadamcik Apr 28, 2026
fff330c
Refactor: simplify capability checks and remove unused methods
Hadamcik Apr 28, 2026
2af3aff
Refactor: remove unused methods and simplify capability handling
Hadamcik Apr 28, 2026
c2aced7
Refactor: centralize `app_path` logic and simplify metadata handling
Hadamcik Apr 28, 2026
1db805a
Refactor: remove redundant manifest helper functions and simplify `en…
Hadamcik Apr 28, 2026
42dd5d0
Refactor: introduce `SageAppUrl` and `SageAppManifestUrl`, reorganize…
Hadamcik Apr 28, 2026
4d89a68
Refactor: remove redundant `limits` module and simplify package valid…
Hadamcik Apr 28, 2026
c45a958
Refactor: relocate manifest tests to `types/manifest.rs` for better o…
Hadamcik Apr 28, 2026
916f2d9
Refactor: integrate `SageAppUrl` for improved URL handling and centra…
Hadamcik Apr 28, 2026
12ed81f
Refactor: replace `UrlInstallSource` with `SageAppUrl` for streamline…
Hadamcik Apr 28, 2026
948d89e
Refactor: streamline app permission updates and introduce `AppUpdateR…
Hadamcik Apr 28, 2026
c2dcc4a
Refactor: simplify `write_installed_app_metadata` by removing redunda…
Hadamcik Apr 28, 2026
0c5a704
Refactor: simplify permission granting logic and replace internal met…
Hadamcik Apr 28, 2026
df9ca87
Refactor: remove redundant bridge event emitters and consolidate perm…
Hadamcik Apr 28, 2026
a6bb090
Refactor: centralize manifest fetching and app URL preview logic
Hadamcik Apr 28, 2026
11cf55a
Refactor: centralize `active_manifest` usage and streamline `SageAppC…
Hadamcik Apr 28, 2026
acf222d
Refactor: introduce `SageAppIdentity` for encapsulating app identity …
Hadamcik Apr 28, 2026
41fbbf8
Refactor: rename `capability_flags` to `flags` and update module path…
Hadamcik Apr 28, 2026
fffd328
Refactor: remove `state` module and consolidate `AppsHostState` into …
Hadamcik Apr 28, 2026
ba89e18
Refactor: consolidate app handling logic and enhance SageApp modularity
Hadamcik Apr 28, 2026
228716f
Move FE to new shape
Hadamcik Apr 28, 2026
e7e95ba
Refactor: move `is_sandbox_test` to `SageAppCommon` and streamline er…
Hadamcik Apr 28, 2026
8236a4c
wip
Hadamcik Apr 29, 2026
89f83fa
WIP
Hadamcik Apr 30, 2026
58cf10b
WIP
Hadamcik Apr 30, 2026
a7775d4
WIP
Hadamcik Apr 30, 2026
e7cb142
Refactor: enhance `build_system_apps` with dist directory checks and …
Hadamcik Apr 30, 2026
7f1131b
Refactor: remove `#[serde(rename_all = "camelCase")]`, improve error …
Hadamcik Apr 30, 2026
e94ea8b
Impostors
Hadamcik Apr 30, 2026
aebf724
Refactor: implement verified storage clear cycle and improve impostor…
Hadamcik May 1, 2026
963d229
Refactor: split storage build logic, enhance clear cycle test, and im…
Hadamcik May 1, 2026
b9957ab
Refactor: replace `invoke` with `commands.appsUpdatePermissions` for …
Hadamcik May 1, 2026
abb6d9d
Refactor: optimize launch gate refresh logic and improve error handling
Hadamcik May 1, 2026
b13a55a
Refactor: rename and streamline app permissions update logic
Hadamcik May 1, 2026
bb48296
Refactor: replace `Deserialize` with `Serialize` for view structs and…
Hadamcik May 1, 2026
284f046
Refactor: update `AppTaskBar` tab handling to use app object references
Hadamcik May 1, 2026
85ecca3
Refactor: remove `channel` property from bridge requests and responses
Hadamcik May 1, 2026
dbf4a5c
Refactor: add `appsInvokeSystemBridge` command and update apps contex…
Hadamcik May 1, 2026
6ea13dd
Refactor: remove async usage from protocol handlers and add immediate…
Hadamcik May 1, 2026
c67febd
Fix: prevent event propagation on AppTaskBar button to avoid unintend…
Hadamcik May 1, 2026
adbeebb
Add active runtime tracking by host window and enhance runtime visibi…
Hadamcik May 1, 2026
d8d4e01
Refactor: unify runtime event handling and streamline event emission …
Hadamcik May 1, 2026
48b0122
Add active runtime change event handling and improve runtime state up…
Hadamcik May 1, 2026
39258dc
Refactor: extract `isActiveRoute` helper to simplify NavLink active s…
Hadamcik May 1, 2026
393ce5f
Improve error handling and logging in `build_builtin_system_app`
Hadamcik May 1, 2026
f0e5e0e
Themes
Hadamcik May 2, 2026
66255c5
Improve `apply_environment_theme` to enhance permission checks
Hadamcik May 2, 2026
54c3b2c
Refactor: add immediate runtime lookup with retry logic
Hadamcik May 2, 2026
c8dfa91
Move capabilities list
Hadamcik May 2, 2026
169e2d4
Refactor: extract `get_protocol_request_runtime` to simplify runtime …
Hadamcik May 2, 2026
9c27fdd
Allow Clippy lint for enum variant naming in capabilities list
Hadamcik May 2, 2026
84aa7b0
Extract `assert_bridge_origin` to `security::bridge` module
Hadamcik May 2, 2026
4704089
Refactor bridge request handling
Hadamcik May 2, 2026
753684d
Refactor bridge types and state for modularity
Hadamcik May 2, 2026
6306aeb
Refactor `event_emit` and bridge imports for improved encapsulation a…
Hadamcik May 2, 2026
0b49d85
Refactor bridge methods and capabilities visibility for enhanced enca…
Hadamcik May 2, 2026
838b577
Refactor runtime and bridge visibility for improved encapsulation and…
Hadamcik May 2, 2026
960b8ae
Update storage capability naming for clarity and consistency
Hadamcik May 2, 2026
ed0e7b8
Refactor `uninstall.rs` for improved error handling, clarity, and mod…
Hadamcik May 2, 2026
f3cdecb
Add `manifestVersion` and `sageVersion` support to manifests
Hadamcik May 2, 2026
6fe21dc
Support partial manifests and improve error handling
Hadamcik May 2, 2026
1bde19f
Add app update review UI and backend support for permission handling
Hadamcik May 2, 2026
4593709
Add `SystemAppModalLayer` for managing system app modals
Hadamcik May 2, 2026
708b9bb
Introduce `@sage-app/ui` package and integrate permissions editor
Hadamcik May 2, 2026
4e8a910
Adjust modal styles, webview transparency, and layout structure
Hadamcik May 2, 2026
ceffe57
Refine modal and app layout styles
Hadamcik May 2, 2026
aabe01f
Refactor `SystemAppModalLayer` for improved runtime synchronization a…
Hadamcik May 2, 2026
ccf666f
Add `theme.css` and integrate shared design tokens
Hadamcik May 2, 2026
4c253fc
Refactor system app build output structure and integrate shared theme
Hadamcik May 2, 2026
d1911c7
Refactor Tailwind configuration and standardize theme integration
Hadamcik May 2, 2026
70b0a39
Improve runtime synchronization during resize in `SystemAppModalLayer`
Hadamcik May 2, 2026
5d5d495
Set `titleBarStyle` to `Transparent` in Tauri config and remove unuse…
Hadamcik May 2, 2026
82a9d02
Integrate `SystemModalShell` and implement `useRuntimeWebviewBounds`
Hadamcik May 2, 2026
70deaca
Refactor build process for system and test apps, integrate `build-bui…
Hadamcik May 2, 2026
d2ff7c9
Refactor system app reload logic and integrate `setupDevSystemAppsRel…
Hadamcik May 3, 2026
f9e24e5
Add selective app rebuilds in build and watch scripts
Hadamcik May 3, 2026
71b61ca
Add `AppModalShell` component and refactor update app modal
Hadamcik May 3, 2026
a49e5bb
Enhance modal theming and layout consistency
Hadamcik May 3, 2026
9abe758
Implement app installation framework and refactor related components
Hadamcik May 3, 2026
0697989
Adjust modal background transparency and footer padding
Hadamcik May 3, 2026
1991f02
Remove `InstallAppForm` and `InstallPermissionsDialog` components
Hadamcik May 3, 2026
e6ad25d
Refactor app icon handling and improve installation workflows
Hadamcik May 3, 2026
f108909
Remove `InstallSummary` component and references in `ReviewInstallView`
Hadamcik May 3, 2026
f96e92c
Refactor `PermissionsEditor` and split into modular components.
Hadamcik May 3, 2026
57a030d
Refactor `PermissionsEditor` for improved layout, styling, and modula…
Hadamcik May 3, 2026
2782f7f
Refactor `PermissionsEditor` to unify optional permissions handling
Hadamcik May 3, 2026
6a99cbb
Add optional network permissions support to `PermissionsEditor`
Hadamcik May 3, 2026
da64870
Remove unused components: `AppUpdateDialog` and `InstallSourceCard`.
Hadamcik May 3, 2026
90f8a64
Simplify `SystemAppPresentation` and refactor related functionality.
Hadamcik May 3, 2026
a297361
Remove `useAppEmbeddedRuntime` and refactor runtime management.
Hadamcik May 4, 2026
1572f76
Refactor runtime event handling in `AppsContext` and improve error lo…
Hadamcik May 4, 2026
78fb42f
Remove deprecated runtime hooks and streamline runtime management.
Hadamcik May 4, 2026
c216cc9
Export utility functions and adjust modal styling.
Hadamcik May 4, 2026
cacf328
Remove Task Manager action from Apps page and actions menu
Hadamcik May 4, 2026
87c851c
Fix runtime webview reload command formatting
Hadamcik May 4, 2026
92a6f66
Migrate approval logic to a standalone app
Hadamcik May 5, 2026
d455ff5
Refactor active taskbar runtime handling and event subscriptions.
Hadamcik May 5, 2026
c5ba1cc
Refactor drag state handling in `AppTaskBar` and runtime state synchr…
Hadamcik May 5, 2026
acd548e
Refactor runtime capabilities and improve theme handling.
Hadamcik May 5, 2026
c2b12ae
Introduce foundation for Sage runtime bridge and theme management.
Hadamcik May 5, 2026
76df95b
Refactor `RustBridgeInvokeResult` handling and improve bridge request…
Hadamcik May 5, 2026
d802716
Refactor runtime event handling and bridge approvals.
Hadamcik May 6, 2026
c5be0de
Add debug utilities for bridging and runtime communications.
Hadamcik May 6, 2026
42f8aa2
Remove built-in apps build logic and usage
Hadamcik May 6, 2026
9c2eab6
Remove `get_builtin_test_app` and related sandbox logic
Hadamcik May 6, 2026
6acdaee
Remove app permissions-related components and utility functions
Hadamcik May 6, 2026
c6e7a12
Refactor `uninstall_app` to streamline storage cleanup logic and impr…
Hadamcik May 6, 2026
54d5945
Refactor app metadata handling and runtime logic
Hadamcik May 6, 2026
cccc05e
Refactor bridge approval logic and remove unused permissions handling
Hadamcik May 6, 2026
1413ff9
Introduce apps workspace management and runtime activation
Hadamcik May 6, 2026
9156268
Refactor runtime visibility and taskbar handling logic
Hadamcik May 6, 2026
233cbef
Refactor workspace runtime flow to improve visibility syncing and eve…
Hadamcik May 6, 2026
a922fae
Refactor runtime state synchronization and visibility handling
Hadamcik May 6, 2026
45b5123
Add priority field to `AppModalPresentation` and refactor runtime vis…
Hadamcik May 6, 2026
32b2bd0
Add stricter CSP rules and forbid service workers in protocol requests
Hadamcik May 7, 2026
377e1e5
Update CSP generation: add new directives and refactor source list ha…
Hadamcik May 7, 2026
dccdf8a
Add `MobileNavSheet` component and integrate into `AppTaskBar` and `H…
Hadamcik May 7, 2026
d32db03
Simplify `dragState` dependency tracking in `AppTaskBar` reorder logic
Hadamcik May 7, 2026
d718bb4
Refactor bridge approval UI components and simplify layout logic
Hadamcik May 7, 2026
c47f276
Refine modal and button styling in `SystemModalShell`, `AppModalShell…
Hadamcik May 7, 2026
12dd494
Add donation system app to enable in-app user donations
Hadamcik May 7, 2026
e0d11bb
Remove `SageAppRuntimeVisibility` and refactor capabilities logic
Hadamcik May 7, 2026
39ccc0c
Modularize donation app components and add reusable utilities
Hadamcik May 7, 2026
24e5d2c
Implement `ListedAppsChangedEvent` and associated functionality
Hadamcik May 7, 2026
31fc689
Add `Sandbox Tests` system app for app sandbox test management
Hadamcik May 7, 2026
58d30a9
Optimize lock retry logic and improve error reporting in `read.rs`
Hadamcik May 7, 2026
7f826f7
Reduce timeout durations and clean up unused retry logic in probes an…
Hadamcik May 7, 2026
df7e666
Highlight selected donation presets based on user input in `AmountPic…
Hadamcik May 7, 2026
8e55c64
Add wallet scoping functionality to app installations
Hadamcik May 7, 2026
f73e8b6
Refactor wallet scoping implementation and migrate `WalletScopeView` …
Hadamcik May 7, 2026
49d6f75
Add app scope enforcement for lifecycle and runtime methods
Hadamcik May 7, 2026
3fe0b4e
Move `ensure_initial_sandbox_run` to app initialization flow
Hadamcik May 7, 2026
2a5ca50
Remove redundant `eprintln!` calls in lock error handling of `read.rs`
Hadamcik May 7, 2026
5225321
Cargo fmt
Hadamcik May 8, 2026
c224c36
Refactor permissions types: split `permissions.rs` into modular compo…
Hadamcik May 8, 2026
e18409f
Refactor app update lifecycle logic and improve state management
Hadamcik May 8, 2026
659a7da
Refactor network permissions logic to support network-specific entries
Hadamcik May 8, 2026
c8e3af5
Refactor permissions and security logic, improve error handling and l…
Hadamcik May 8, 2026
a54d0d8
Refactor sandbox runner and logging, improve state management and err…
Hadamcik May 8, 2026
fff3c29
Refactor protocol handling to support async responses and improve err…
Hadamcik May 8, 2026
4f1f7ad
Reduce timeouts for improved responsiveness in protocol and state man…
Hadamcik May 8, 2026
f3d883a
Remove verbose tracing and logging in `sandbox_runner`, streamline st…
Hadamcik May 8, 2026
46f31ce
Add network-specific permission handling and runtime reload logic
Hadamcik May 8, 2026
2bca6a0
Remove `downloadAppUpdate` logic and introduce pending update events
Hadamcik May 8, 2026
8ec83ce
Refactor background tint logic for modularity and reuse
Hadamcik May 8, 2026
0b8f650
Introduce background app update checker and streamline update logic
Hadamcik May 9, 2026
06625fe
Remove `AppDonationStrip` component and enhance background update han…
Hadamcik May 9, 2026
567267c
Refactor app update preview logic with `AppUpdatePreviewResult`
Hadamcik May 9, 2026
d8bfd02
Refactor app routing and improve tab management
Hadamcik May 9, 2026
ca1cc26
Refactor runtime management and app handling
Hadamcik May 9, 2026
d9e383c
Refactor app update handling and permissions logic
Hadamcik May 9, 2026
62d4380
Update wording for app update context menu option to "Review update" …
Hadamcik May 10, 2026
dc80bc0
Add `AppUpdateLockGuard` for concurrent app update management
Hadamcik May 10, 2026
4714bd1
Remove `PendingUpdateActivity` and related logic
Hadamcik May 10, 2026
9bd43b3
Refactor codebase for mobile compatibility and plugin updates:
Hadamcik May 10, 2026
c7364be
Cargo fmt
Hadamcik May 10, 2026
c309f59
Update button wording from "Send donation" to "Send support" in Donat…
Hadamcik May 10, 2026
8afd6b9
Split app update logic into separate modules and introduce global set…
Hadamcik May 10, 2026
24e3ee2
Rename app commands for consistency and add support for auto-update t…
Hadamcik May 10, 2026
5e2f2af
Refactor storage types: merge `InstalledSageAppStorage` and `PendingS…
Hadamcik May 11, 2026
9af528c
Introduce database-backed storage and origin management for Sage apps
Hadamcik May 21, 2026
b5ba7b1
Remove `SageAppFlags` and related logic, refactor Sage app state mana…
Hadamcik May 21, 2026
2a97912
Refactor lifecycle and mutation logic for Sage apps:
Hadamcik May 21, 2026
5511cd5
Remove origin management logic and unused database methods for Sage a…
Hadamcik May 21, 2026
3e2f003
Refactor app snapshot handling and database schema:
Hadamcik May 22, 2026
94a45e0
Remove storage clear cycle logic:
Hadamcik May 22, 2026
fb73afa
Introduce `origin-cleanup` app for clearing browser-origin data:
Hadamcik May 22, 2026
dc14526
Remove `storage_clear_cycle` capability and related logic from sandbo…
Hadamcik May 22, 2026
2ad428b
Add tests for abandoned unmanaged storage cleanup and refactor error …
Hadamcik May 22, 2026
b304694
Use `inputToGrantedPermissionsView` for permission state transformati…
Hadamcik May 22, 2026
c3bf7be
Add checkbox for toggling primary scheme permissions in `PermissionRo…
Hadamcik May 22, 2026
3d98325
Refine `PermissionsEditor` logic to synchronize `nextKeys` with `requ…
Hadamcik May 22, 2026
e95f2ee
Update `CapabilityHelp` popover styling and background logic
Hadamcik May 22, 2026
929a433
Add scroll-to-end validation for updating and installing apps
Hadamcik May 22, 2026
448f95b
Handle persistent storage permission changes during app updates
Hadamcik May 22, 2026
a1eee6e
Remove unnecessary raw string syntax (`r#`) from SQL queries in `Apps…
Hadamcik May 22, 2026
605029f
Clippy
Hadamcik May 22, 2026
ee1211b
Fmt
Hadamcik May 22, 2026
fd362d3
Remove `AppMutationDraft` implementation from lifecycle mutation oper…
Hadamcik May 22, 2026
48394ea
Update `has_external_access` to account for non-empty network whiteli…
Hadamcik May 22, 2026
6ee09b3
Improve handling of approval expiry tasks and add stricter validation…
Hadamcik May 22, 2026
51cb252
Add unit tests for `unzip_to_dir` and `ensure_capability_requestable_…
Hadamcik May 22, 2026
a525a74
Remove `wallet.getKeys` method and associated capabilities
Hadamcik May 22, 2026
b89f66e
Remove `apps_get_user_capability_definitions` method and associated r…
Hadamcik May 22, 2026
3a5d59c
Migrate app settings to database-backed storage and remove filesystem…
Hadamcik May 22, 2026
cf4b531
Add `environment.getNetwork` method and capability
Hadamcik May 23, 2026
fa40921
Validate network hostnames with `is_csp_safe_host` and add unit tests…
Hadamcik May 23, 2026
28b419d
Validate package contents and enforce file declarations in `prepare_z…
Hadamcik May 23, 2026
2da250b
Refactor validation and error handling in `snapshot` and `package` mo…
Hadamcik May 23, 2026
3a300ce
Add tests for rejecting sensitive capabilities with external access p…
Hadamcik May 23, 2026
8b39bc0
Add unit tests for permission updates and pending update decisions
Hadamcik May 23, 2026
d22bbc0
Enforce remote app icon size limit and improve error handling
Hadamcik May 23, 2026
7c83933
Add unit tests for network-specific CSP whitelist behavior
Hadamcik May 23, 2026
913c067
Add unit tests for `SageAppSnapshot` file path resolution and securit…
Hadamcik May 23, 2026
4ce755e
Refactor app protocol file path resolution logic into a dedicated fun…
Hadamcik May 24, 2026
574ff25
Fix typo in Task Manager title
Hadamcik May 24, 2026
ce63f6d
Rename mod.rs files
Rigidity May 31, 2026
2461674
Add cursor rule
Rigidity May 31, 2026
a4f0ca7
Fix imports v1
Rigidity May 31, 2026
27d4cb5
Group imports
Rigidity May 31, 2026
0fb3620
fmt
Rigidity May 31, 2026
f565a48
Fixes
Rigidity May 31, 2026
30b9675
Add state back
Rigidity May 31, 2026
9ab324e
Merge pull request #3 from xch-dev/apps-review
Hadamcik May 31, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
38 changes: 38 additions & 0 deletions .cursor/rules/imports.mdc
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
description: Rust module and import practices
globs: **/*.rs
alwaysApply: false
---

# Rust Modules And Imports

For Rust files:

- `crates/sage-apps/src/lib.rs` is exempt from this rule.
- Group imports as `std`, external crates, then `crate`, with blank lines between groups.
- Put `mod` groups first, then `pub use`, then less-visible `use` groups.
- Within each `mod`/`use` group, don't add blank lines; only separate groups.
- After `mod`, group statements of the same kind by visibility, most visible first (`pub`, `pub(crate)`, private).
- Prefer `use` imports over repeated long paths in signatures/bodies.
- Import crate-local items directly from `crate` (`use crate::{A, b};`), not `crate::submodule`; use at most one crate brace group per scope/module.
- Keep conventional qualifiers when clearer, e.g. `use std::fmt; impl fmt::Display ...`.
- Put visibility on the item definition, not the re-export, where possible.
- Re-export child modules with `pub use child::*;` where possible; only use more restrictive re-export visibility if linting shows none of the child items are public.
- Re-export intended child items from parent modules instead of forcing callers through long internal paths.
- Avoid unrelated import/re-export churn.

```rust
mod registry;

pub use registry::*;

use std::fmt;

use crate::SageApp;

impl fmt::Display for Error {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
// ...
}
}
```
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ target
.env
/test.sqlite*

/builtin-apps/build/
Loading