Skip to content

Update attach-static-vdis - Fix failed service.#7122

Open
IgorGlock wants to merge 1 commit into
xapi-project:masterfrom
IgorGlock:patch-1
Open

Update attach-static-vdis - Fix failed service.#7122
IgorGlock wants to merge 1 commit into
xapi-project:masterfrom
IgorGlock:patch-1

Conversation

@IgorGlock

Copy link
Copy Markdown

This should fix this issue:

# /opt/xensource/libexec/attach-static-vdis start

Attempting to attach all statically-configured VDIscat: /etc/xensource/static-vdis/*/vdi-uuid: No such file or directory

This is my first pull request.

This should fix this issue:
# /opt/xensource/libexec/attach-static-vdis start

Attempting to attach all statically-configured VDIscat: /etc/xensource/static-vdis/*/vdi-uuid: No such file or directory

Signed-off-by: IgorGlock <IgorGlock@users.noreply.github.com>
if [ -z "$(find ${STATE_DIR} -mindepth 1)" ]; then
# directory is empty
exit 0
fi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the issue of empty dir you can add shopt -s nullglob somewhere at the beginning so it won't expand empty dir. What do you think?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And thanks for your first PR by the way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants