Skip to content

feat: fused GLM kPool indexer for NPU. - #2287

Draft
sanlio36 wants to merge 3 commits into
xLLM-AI:preview/glm-5.3-flashfrom
sanlio36:preview/glm-5.3-flash
Draft

feat: fused GLM kPool indexer for NPU. #2287
sanlio36 wants to merge 3 commits into
xLLM-AI:preview/glm-5.3-flashfrom
sanlio36:preview/glm-5.3-flash

Conversation

@sanlio36

Copy link
Copy Markdown
Collaborator

Description

Related Issues

Change Type

  • Bug fix
  • New feature
  • Performance improvement
  • Refactor
  • Documentation
  • Test
  • Build or CI

Pull Request Checklist

Thank you for contributing to xLLM. Before requesting review, please make sure the following items are complete.

PR Title and Commit Messages

  • The PR title and each commit message follow the xLLM commit format: <type>: <subject>.

Allowed types: feat, bugfix, docs, test, refactor, chore, style, revert, perf, model, build, release.
The subject should use clear English, start with a verb, include at least 4 words, and end with ..

Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit or an equivalent command.
  • I have installed the hooks with pre-commit install.
  • I have run pre-commit run --all-files and fixed any reported issues.

If you are unsure how to set up pre-commit, see the pre-commit documentation.

Self Review

  • I have self-reviewed the code according to .agents/skills/code-review/references/custom-code-style.md, especially code written or assisted by AI.
  • I have rebased this PR onto the latest main branch.

Build and Test Coverage

  • Tests have been added or updated as needed.
  • CUDA: python setup.py build test has passed on a CUDA machine.
  • NPU: python setup.py build test has passed on an NPU machine.
  • MLU: python setup.py build test has passed on an MLU machine.

Reviewer Notes

- keep the small-operator path when index_kpool_compress is disabled or the fused operator is unavailable
- preserve the packed GLM index cache layout only for NPU
- compare fused outputs with a deterministic reference in the NPU pytest
Use BSND fused indexing for eager decode and PA_BBND fused indexing during ACL graph decode.

Support BSND, TND, and PA_BBND layouts in the NPU wrapper with focused pool-size coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant