Repository navigation
Conversation
Focusing the player name field now lists recent players right away, without typing first. Names come from the newest games first, skip anyone already seated in this game, and leave out default "Player N" names. Typing still searches every saved name, and clearing the field brings the recent list back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From user feedback: in games with many players (7 Wonders), you had to type part of every name before any suggestions appeared.
Now, focusing a player's name field shows a Recent players list right away:
Player NnamesTyping still searches every saved name, as before. Clearing the field shows the recent list again.
Changes
redux/selectors.ts: new memoizedselectRecentPlayerNamessrc/screens/EditPlayerScreen.tsx: until the name is edited (or once it's cleared), show recent players with a header; after typing, show filtered matches as beforeTesting
npm run lintandnpm run test(475 passing)🤖 Generated with Claude Code