wx.lib.inspection dark mode issues [Issue #2917] - #2925
Open
CEXT-Dan wants to merge 8 commits into
Open
Conversation
this commit partially fixes the dark mode issues by making the editor window readable when in dark mode
Author
|
sorry, actually, this does not work with the sample I posted in #2917 |
made faces a method
Author
|
now the sample works |
swt2c
requested changes
Jul 28, 2026
| try: | ||
| is_dark = wx.SystemSettings.GetAppearance().IsDark() | ||
| except wx.PyNoAppError: | ||
| is_dark = False |
Collaborator
There was a problem hiding this comment.
Can we fix this for platforms other than MSW as well? Maybe factor out the color setting to be for all platforms, since the colors are the same for all platforms?
Collaborator
There was a problem hiding this comment.
It looks like you tried to address this, but it seems that you need to move the is_dark definition outside of if 'wxMSW' in wx.PlatformInfo
remove global add dark colors for all platforms
remove extra import
swt2c
reviewed
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit partially fixes the dark mode issues in wx.lib.inspection
by making the editor window readable when in dark mode
Fixes #2917