wx.lib.inspection dark mode issues [Issue #2917] - #2925
Conversation
this commit partially fixes the dark mode issues by making the editor window readable when in dark mode
|
sorry, actually, this does not work with the sample I posted in #2917 |
made faces a method
|
now the sample works |
| try: | ||
| is_dark = wx.SystemSettings.GetAppearance().IsDark() | ||
| except wx.PyNoAppError: | ||
| is_dark = False |
There was a problem hiding this comment.
Can we fix this for platforms other than MSW as well? Maybe factor out the color setting to be for all platforms, since the colors are the same for all platforms?
There was a problem hiding this comment.
It looks like you tried to address this, but it seems that you need to move the is_dark definition outside of if 'wxMSW' in wx.PlatformInfo
remove global add dark colors for all platforms
remove extra import
|
Now that we have the unittests up and running in CI/CD, can you either rebase or merge master into this branch so they run? Also, can you add a unittests for this functionality, if one doesn't already exist? |
|
Sorry boss, I’m way out of my league here, I changed all the CI/CD on my fork. It’s way out of date. happy to create a test in another PR. I probably need to redo my fork |
|
I can take care of it, if you'd like? |
|
That would be great. I made a post on the forum asking for advice on how to contribute, maybe that will help me out in the future |
2 participants
this commit partially fixes the dark mode issues in wx.lib.inspection
by making the editor window readable when in dark mode
Fixes #2917