Permit building against system wxWidgets built without WebView support - #2900
Open
spillner wants to merge 1 commit into
Open
Permit building against system wxWidgets built without WebView support#2900spillner wants to merge 1 commit into
spillner wants to merge 1 commit into
Conversation
…t (i.e. do not assume WebView headers are installed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2825.
etg/webview.pyand thesip/gen/webview.sipthat it generates both go to a lot of trouble to provide dummy stubs for the WebView API, but the generated headers still assume that<wx/webview*.h>are present, which won't be the case if wxWidgets was indeed built without WebView support.Since WebView depends on WebKit, which has large number of known and suspected security issues and no longer receives maintenance updates, requiring WebKit support in wxWidgets in order to build wxPython unnecessarily increases the attack surface of the host system.
The
optional_wx_modules = [...]definition inetgtools/sip_generator.pycan be expanded to allow wxPython to be built on systems without other nonessential wxWidgets modules, if desired.