You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry, I hadn't checked the bitmap drawing test. I've confirmed that the bitmap position is also incorrect.
But I just pushed one more commit—could you revert or reopen this? Sorry for the inconvenience.
I’m not sure this fix is gonna cut it.
The // operator no longer converts to int.
it just gives the floor of the number but can return float.
so I think you’re going to have to explicitly convert to int to satisfy all cases.
I can see that, but it doesn't cover all cases. I also tested the Allow and AllowLine cases and confirmed that they have issues as well. The issue comes from passing a float value to dc.DrawXXX.
I will check some more and submit a PR later and would appreciate it if you could review it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2748
This PR modifies "wx/lib/floatcanvas/FCObjects.py" and is part of #2448, which currently has conflicts.