Skip to content

Create LICENSE file in the root - #2737

Open
fredgan wants to merge 1 commit into
wxWidgets:masterfrom
fredgan:patch-1
Open

Create LICENSE file in the root#2737
fredgan wants to merge 1 commit into
wxWidgets:masterfrom
fredgan:patch-1

Conversation

@fredgan

@fredgan fredgan commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

It's not easy to know the LICENSE of this project. So I copy the license contents from page https://wxpython.org/pages/license/

It's also the best practice of common open source projects. Hoping this can be merged.

@echoix

echoix commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

@swt2c Wasnt some files generated when building the source archive for this? I can't find them committed (at least on mobile)

Curiosly I noticed the same this weekend, that the license isn't interpreted in GitHub UI's, as we don't have a file stating the license text plainly.

@swt2c

swt2c commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

Yeah, the license file is generated during the build for the sdist in build.py and buildtools/config.py, but perhaps it could be static instead. Will have to think about this.

@fredgan

fredgan commented Apr 25, 2025

Copy link
Copy Markdown
Contributor Author

@swt2c Do you have any ideas or plans about this currently?

@swt2c

swt2c commented May 5, 2025

Copy link
Copy Markdown
Collaborator

I need more time to think about it / review.

@newville

Copy link
Copy Markdown
Contributor

A LICENSE file in the root folder does seem necessary. I understand the complication of several licenses to report for all the sub-packages used. The LICENSE file @fredgan proposes seems sufficient.

If that seems too simplistic, maybe add to that file a link to https://wxpython.org/pages/license/index.html that expresses that complication of "lots of dependencies".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants