Conversation
Signed-off-by: Nicolas Pais <nick@nickserver.net>
|
|
|
Hi @Nickmman, Thank you for submitting this PR. My only concern with this fix is: it requires TLS secrets to be available during Ingress creation, introducing an additional dependency that could break the default deployment behavior. To improve flexibility, I suggest making the use of the TLS |
Purpose
Resolves the issue where TLS spec is broken, it is missing the required secretName.
Goals
Ingress objects get created properly.
Approach
Adding secretName, prefixed with
tls-, completed via the hostname being used in each Ingress objects.Also, adjusted indentation to follow Kubernetes documentation.
User stories
Release note
Add missing TLS secretName to Ingress.
Documentation
N/A - Value is automatically calculated.
Training
Certification
Marketing
Automation tests
Security checks
Samples
Currently deploying via ArgoCD, Ingresses currently fail to be created, due to
Skipped a TLS block: spec.tls[0].secretName: Required valueRelated PRs
Migrations (if applicable)
Test environment
Learning