Skip to content

Add missing TLS secretName - #585

Open
Nickmman wants to merge 1 commit into
wso2:4.2.xfrom
Nickmman:ingress-tls-secret-name
Open

Nickmman wants to merge 1 commit into
wso2:4.2.xfrom
Nickmman:ingress-tls-secret-name

Conversation

@Nickmman

Copy link
Copy Markdown

Purpose

Resolves the issue where TLS spec is broken, it is missing the required secretName.

Goals

Ingress objects get created properly.

Approach

Adding secretName, prefixed with tls-, completed via the hostname being used in each Ingress objects.
Also, adjusted indentation to follow Kubernetes documentation.

User stories

Summary of user stories addressed by this change>

Release note

Add missing TLS secretName to Ingress.

Documentation

N/A - Value is automatically calculated.

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Currently deploying via ArgoCD, Ingresses currently fail to be created, due to Skipped a TLS block: spec.tls[0].secretName: Required value

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Signed-off-by: Nicolas Pais <nick@nickserver.net>
@CLAassistant

CLAassistant commented Jun 29, 2023

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@PasanT9

PasanT9 commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Hi @Nickmman,

Thank you for submitting this PR. My only concern with this fix is: it requires TLS secrets to be available during Ingress creation, introducing an additional dependency that could break the default deployment behavior.

To improve flexibility, I suggest making the use of the TLS secretName configurable. We could achieve this by adding a new parameter in values.yaml, enabling users to choose whether to include TLS in their deployment based on their specific requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants