Skip to content

Set the labels to be what is in extra state - #584

Merged
lizlooney merged 1 commit into
wpilibsuite:mainfrom
alan412:fix_svg_generation_for_component_holder
Oct 23, 2026
Merged

lizlooney merged 1 commit into
wpilibsuite:mainfrom
alan412:fix_svg_generation_for_component_holder

Conversation

@alan412

@alan412 alan412 commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

Overview

This sets the label of the component holder for a robot to what is in the extra state instead of starting out as the empty string. This allows our documentation tool to capture an accurate SVG

Linked Issues

None

Type of Change

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that causes existing functionality to change)
  • Documentation update
  • Code style/formatting updates
  • Refactoring / Renaming
  • Other

How Has This Been Tested?

Checked the created SVG from the scripts directory
Also tested in blocks to make sure it didn't have any unintended side effects

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [N/A] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run through the [docs/testing_before_pr_checklist.md]

@alan412
alan412 requested a review from lizlooney October 23, 2026 16:20
@lizlooney
lizlooney merged commit 3b47ab1 into wpilibsuite:main Oct 23, 2026
1 check passed
@alan412
alan412 deleted the fix_svg_generation_for_component_holder branch October 23, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants