Skip to content

Fix crash with gamepad - #583

Merged
lizlooney merged 3 commits into
wpilibsuite:mainfrom
alan412:fix_crash
Oct 21, 2026
Merged

lizlooney merged 3 commits into
wpilibsuite:mainfrom
alan412:fix_crash

Conversation

@alan412

@alan412 alan412 commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Overview

It turns out the gamepad had the same issue as port blocks before that only shows up with the Zelos (and FIRST style which is derived from it) styles.

In addition to fixing that, I did a pass through and every other dropdown we have I changed to the new dropdownWithRectangle so that if a user library starts one with a shadow it will not crash.

That created a problem for the color dropdown where the arrow was in the wrong place so I changed it as well.

Linked Issues

None

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that causes existing functionality to change)
  • Documentation update
  • Code style/formatting updates
  • Refactoring / Renaming
  • Other

How Has This Been Tested?

Put Gamepad in Teleop
Ran through checklist to make sure it didn't break anything else

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [N/A] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run through the [docs/testing_before_pr_checklist.md]

@alan412
alan412 requested a review from lizlooney October 21, 2026 21:03
@lizlooney
lizlooney merged commit 9609ab3 into wpilibsuite:main Oct 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants