Skip to content

Closes #8451 Show Rocket Insights CDN recommendation based on RocketCDN subscription state - #8646

Open
Khadreal wants to merge 8 commits into
developfrom
enhancement/8451-rocket-recommendation
Open

Closes #8451 Show Rocket Insights CDN recommendation based on RocketCDN subscription state#8646
Khadreal wants to merge 8 commits into
developfrom
enhancement/8451-rocket-recommendation

Conversation

@Khadreal

Copy link
Copy Markdown
Contributor

Description

Modify the RI logic for different RocketCDN state

Fixes #8451

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • Sub-task of #(issue number)
  • Chore
  • Release

Detailed scenario

What was tested

  • Test with RocketCDN no activated
  • Test with RocketCDN free subscription
  • Test with RocketCDN pro subscription

How to test

  • Check the recommendation when RocketCDN is activated with free subscription
  • Check the recommendation when RocketCDN is activated with pro subscription
  • Check the recommendation when RocketCDN is not activated

Affected Features & Quality Assurance Scope

Affect RI recommendation sidebar.

Technical description

Documentation

Add new param plugin_rocketcdn_free for rocketcdn.

New dependencies

n/a

Risks

n/a

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

n/a

@Khadreal Khadreal self-assigned this Jul 22, 2026
@codacy-production

codacy-production Bot commented Jul 22, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 110 complexity

Metric Results
Complexity 110

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@Khadreal
Khadreal requested a review from a team July 22, 2026 08:59

@jeawhanlee jeawhanlee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this also needs work on the Addons part
CC @wordpressfan

Comment thread inc/Engine/CDN/RocketCDN/AdminPageSubscriber.php
Comment thread inc/Engine/CDN/RocketCDN/AdminPageSubscriber.php Outdated
@hanna-meda

hanna-meda commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@Khadreal, to have in mind also these 3 points (confirmed by PO in Slack thread):

  1. Besides the upgrade-to-Pro copy, we're also seeing "TTFB/LCP improvement 10-40%."
    Expected: We should only see "Speed up your entire site worldwide by delivering content from servers closer to your visitors."
  2. The upgrade-to-Pro recommendation is also showing for resellers.
    Expected: Shouldn't be visible for resellers for now.
  3. Change the "ACTIVATE" CTA to "UPGRADE" going to the Content Delivery page with the Upsell banner opened.
Screenshot 2026-07-28 at 19 29 12

@Khadreal

Copy link
Copy Markdown
Contributor Author

@Khadreal, to have in mind also these 3 points (confirmed by PO in Slack thread):

  1. Besides the upgrade-to-Pro copy, we're also seeing "TTFB/LCP improvement 10-40%."
    Expected: We should only see "Speed up your entire site worldwide by delivering content from servers closer to your visitors."
  2. The upgrade-to-Pro recommendation is also showing for resellers.
    Expected: Shouldn't be visible for resellers for now.
  3. Change the "ACTIVATE" CTA to "UPGRADE" going to the Content Delivery page with the Upsell banner opened.
Screenshot 2026-07-28 at 19 29 12

@DahmaniAdame except number 2, I think the copy can be updated on the performance recommendation backend.

@Khadreal
Khadreal requested a review from jeawhanlee July 30, 2026 10:39
@Mai-Saad

Copy link
Copy Markdown
Contributor

@Khadreal Thanks for the PR. Please find test notes:

@Mai-Saad

Mai-Saad commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

We need to recheck this after refactor

  • Test steps needs to be updated
  • Brainstorm checklist (ensure it's covered in TP)
    Paid cdn active => no RCDNR
    Paid cdn inactive => CDNR to activate it
    free cdn active => CDNR to upgrade it
    free cdn inactive => CDNR to activate it
    YOcdn while free active => CDNR to upgrade it
    YOCDN while free inactive => CDNR to activate it
    YOCDN active/inactive ===> same as 2 above
    pending deletion free =>
    pending deletion paid =>
    white label don't see upgrade while free on/off
    reseller don't see upgrade while free on/off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show Rocket Insights CDN recommendation based on RocketCDN subscription state

5 participants