Skip to content

capture cache clear regression using helper - #390

Open
Mai-Saad wants to merge 3 commits into
developfrom
enhancement/capture-cache-clear-with-refresh
Open

capture cache clear regression using helper#390
Mai-Saad wants to merge 3 commits into
developfrom
enhancement/capture-cache-clear-with-refresh

Conversation

@Mai-Saad

Copy link
Copy Markdown
Contributor

Description

Done by AI + discussions

Fixes #383
Capture cache clear regression using helper wp-media/wp-rocket-e2e-test-helper#15

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • Sub-task of #(issue number)
  • Chore
  • Release

Detailed scenario

What was tested

  • Run the test with buggy zip & the helper PR => test fails
  • Run the test with good zip and the helper PR => test pass

How to test

  • Run all e2e , should be green

Affected Features & Quality Assurance Scope

N/A

Technical description

Documentation

  • Cache home then refresh admin then check if cache is preserved
  • Note: with current version of helper, cache step itself won't pass as login to admin will clear cache with buggy zip (good that test is failing)

New dependencies

  • New version of helper plugin

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

N/a

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@Mai-Saad

Copy link
Copy Markdown
Contributor Author
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

As a QA Engineer, I want e2e to cover test that cache isnot cleared with admin refresh

1 participant