Fixes sub-task #308: folder clearing paths - #316
Conversation
|
@hanna-meda Firstly I must appreciate your work and your effort on this PR, A lot of ciritical thinking and logic put into this. However I think we are making e2e do too much with this PR, I personally like to keep logics that tries to create, read, update files/directories out of e2e and in the helper plugin. I think we should consider this approach moving forward. The idea is e2e will talk with the helper plugin and it would do the heavy lifting of checking directories and file modifications if necessary, I believe this would be easy and straight forward on the PHP side rather on e2e. WDYT? If this is ok by you, you could create an issue on the helper repo and we'll take it from there while you modify this PR, but I think this will happen in another CD sprint. |
|
Thank you @jeawhanlee for the valuable feedback, much appreciated. I've opened this helper ticket to address it: wp-media/wp-rocket-e2e-test-helper#7. I'll block this PR and revisit once the helper has the needed functionality. |
Description
Fixes #308
Adds directory existence/emptiness checks and two new Self-host Google Fonts scenarios to verify cache folders cleanup when toggling Self-host GF with RUCSS on/off.
Type of change
Detailed scenario
What was tested
Ran
npm run test:testfor the newly added scenarios under self-host-google-fonts.feature:Test results screenshot:

How to test
Add @test to the two new scenarios in
src/features/self-host-google-fonts.feature, then runnpm run test:test.Or run the whole feature with
npm run test:selfhostgooglefonts(no tags needed).Technical description
Documentation
E2E coverage was updated with two new self-host GF scenarios and added folder existence/emptiness checks
New dependencies
N/A
Risks
List possible performance & security issues or risks, and explain how they have been mitigated.
Mandatory Checklist
Code validation
Code style
Unticked items justification
N/A
Additional Checks