Closes #37: Refactor rmdir() to use public APIs instead of reflection

[remyperona]

🤖 AI-generated — created by an automated pipeline. Review before acting on this.

Closes #37

Description

Refactors VirtualFilesystemDirect::rmdir()'s recursive branch to eliminate reflection on vfsStream's private internals, improving maintainability and reducing coupling to vfsStream's internal implementation details.

What was done

• Child name retrieval: Replaced reflection of private name property with the public vfsStreamAbstractContent::getName() getter.
• Parent path derivation: Instead of reflecting vfsStream's private parentPath, the parent path is now derived from the directory's own absolute path using PHP's dirname() function.
• Parent directory fetching: Parent directory is retrieved via the existing public-API getDir() helper and passed to removeChild() with an instanceof vfsStreamContainer type guard for safety.
• Cleanup: Removed now-unused use TestCaseTrait; and vfsStreamAbstractContent import; added vfsStreamContainer for the type guard. TestCaseTrait::getNonPublicPropertyValue() remains unchanged and is still used elsewhere.

Files changed

• VirtualFilesystemDirect.php
• Tests/Unit/VirtualFilesystemDirect/rmdir.php — added 2 new tests:
  • Nested recursive removal while preserving siblings
  • Recursive removal via vfs:// URL

How to test

• Run composer run-script test-unit — all 93 unit tests pass with 295 assertions, 0 failures
• Public behavior of rmdir() is unchanged; only the internal implementation refactored
• Integration suite not run locally (requires WP/MySQL environment not available; this change has no WP dependencies)

Type of change

• Refactoring (improving code quality, structure, or maintainability without changing behavior)
• Bug fix
• New feature

Affected Features & Quality Assurance Scope

• Core virtual filesystem operations (directory removal)
• Unit test coverage for recursive directory deletion

Technical description

The refactoring replaces direct reflection into vfsStream's internal properties with calls to public APIs. Previously, the code accessed vfsStreamAbstractContent::$name and parentPath directly via TestCaseTrait::getNonPublicPropertyValue(). Now:

1. Child name is fetched via the public getName() method
2. Parent path is computed from the directory's absolute path using dirname()
3. The parent directory reference is obtained via the existing getDir() public helper
4. An instanceof vfsStreamContainer guard ensures the parent supports removeChild() before calling it

This approach is more resilient to vfsStream upgrades and improves code clarity.