feat: introduce sandbox environment support#385
Open
paolodamico wants to merge 2 commits into
Open
Conversation
brian-terczynski
left a comment
There was a problem hiding this comment.
LGTM but will let someone with more familiarity provide the approval. Thanks for the changes!
brian-terczynski
approved these changes
Jul 15, 2026
brian-terczynski
left a comment
There was a problem hiding this comment.
Bumping this to approval so we can move forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fairly explanatory. Reference project linked in the code.
Note
Medium Risk
New public enum variant affects all clients via UniFFI; misconfigured sandbox could point at wrong contracts or attestation trust if other env matches were missed (this diff only updates the sites shown).
Overview
Adds a third
BedrockEnvironment::Sandboxvalue (UniFFI-exposed) with wire string"sandbox"and docs describing it as an external TFH testing environment that still uses World ID staging protocol settings.Sandbox is treated like staging everywhere this PR touches environment branching: Nitro enclave attestation uses staging PCR configs and the staging AWS Nitro root cert;
world_gift_manager_addressand test helperaddress_book_addressresolve to the same contract addresses as staging.Minor comment whitespace fixes in
nitro_enclave/mod.rsonly.Reviewed by Cursor Bugbot for commit aed7f07. Bugbot is set up for automated code reviews on this repo. Configure here.