Remove obsolete WooCommerce .eot font URLs - #2215
Open
sornapudisuresh wants to merge 1 commit into
Open
sornapudisuresh wants to merge 1 commit into
sornapudisuresh wants to merge 1 commit into
Conversation
WooCommerce no longer ships star.eot / WooCommerce.eot, which caused 404s from Storefront's @font-face rules. Keep the remaining formats and prefer woff2 for WooCommerce where available. Fixes woocommerce#2176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.eot(and IE#iefix) font sources from Storefront’s WooCommerce@font-facerules.woff/ttf/svg, and preferWooCommerce.woff2where WooCommerce still ships it.WooCommerce removed the
.eotassets upstream, so browsers were requesting files that 404.Fixes #2176
Test plan
star.eotorWooCommerce.eot