Fix for using STM32 AES hardware crypto with WOLFSSL_ARMASM set#10311
Open
dgarske wants to merge 1 commit intowolfSSL:masterfrom
Open
Fix for using STM32 AES hardware crypto with WOLFSSL_ARMASM set#10311dgarske wants to merge 1 commit intowolfSSL:masterfrom
dgarske wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts AES-GCM key setup to avoid the ARM assembly AES ECB helper when building for STM32 hardware crypto, preventing use of an implementation that requires an expanded key schedule.
Changes:
- Adds STM32-specific rationale and disables the
WOLFSSL_ARMASMpath whenSTM32_CRYPTOis enabled. - Ensures AES-GCM key setup can fall back to the STM32 CRYP-backed encrypt path rather than
AES_ECB_encrypt.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Member
Author
|
Jenkins retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for using STM32 AES hardware crypto with WOLFSSL_ARMASM set (ZD 21262)
Testing
Using actual STM32F4 hardware and new wolfssl-examples-stm32 coming soon.
Checklist