Skip to content

Add default loginTimer and regress test#950

Merged
ejohnstown merged 2 commits intowolfSSL:masterfrom
yosuke-wolfssl:f_2472
Apr 23, 2026
Merged

Add default loginTimer and regress test#950
ejohnstown merged 2 commits intowolfSSL:masterfrom
yosuke-wolfssl:f_2472

Conversation

@yosuke-wolfssl
Copy link
Copy Markdown
Contributor

@yosuke-wolfssl yosuke-wolfssl commented Apr 23, 2026

This PR adds the following things:

  • Add default value for LoginGraceTime
  • Add regress test and fix minor issues in apps/wolfsshd/test/test_configuration.c
  • Add log for LoginGraceTime on windows since it's not enforced on that

@yosuke-wolfssl yosuke-wolfssl self-assigned this Apr 23, 2026
Copilot AI review requested due to automatic review settings April 23, 2026 06:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Sets a non-zero default for LoginGraceTime in wolfsshd configuration initialization to mitigate resource exhaustion from connections that never complete the SSH handshake.

Changes:

  • Initialize WOLFSSHD_CONFIG.loginTimer to a default of 120 seconds in wolfSSHD_ConfigNew().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/wolfsshd/configuration.c
Comment thread apps/wolfsshd/configuration.c
@yosuke-wolfssl yosuke-wolfssl changed the title Add default loginTimer Add default loginTimer and regress test Apr 23, 2026
@ejohnstown ejohnstown merged commit fdf621c into wolfSSL:master Apr 23, 2026
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants