Fix strict-security env and function runtime grants#370
Open
wolfy-j wants to merge 2 commits into
Open
Conversation
skhaz
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env.storage.routerdirectly with the central env registry before publishing theStorageRegisterevent.security:declared on Lua function and bytecode-function configs at execution time.Why
Kickside exposed two runtime-level contract gaps during strict-security boot:
env.variableentries could observestorage not foundand fail permanently depending on event ordering.wippy.facade,wippy.views, and app public-login handlers already declare runtime policies onfunction.luaentries. Upstream runtime decoded nosecurityfield for Lua funcs, so those handlers ran without their declared policies. The result was empty facade config,public.jsfailures, and login-path failures under the strict model.Together these make package-declared runtime security deterministic without app-level hardcoded grants.
Compatibility
StorageRegisterevent is still emitted unchanged.env.storage.routernow matches the synchronous registration behavior of file, memory, os, and static env storage managers.security:is additive for existing apps: entries without it behave as before.Tests
go test ./service/env/... ./system/env/...go test ./runtime/lua/component/function ./system/securitygo test ./api/env ./api/runtime/lua ./runtime/lua/component/function ./service/env/... ./system/env/... ./system/security ./boot/components/env/...go test ./runtime/lua/modules/process ./system/contractgo test ./...make build-wippy-localKickside smoke was validated with the PR-built binary:
GET /api/public/facade/configreturned populated facade/env values.GET /api/public/env/public.jsreturned populated JS env.GET /returned200.GET /app/login.htmlreturned200.401 Invalid credentialsinstead of the previous nil-db500.