feat: add support for ipyvuetify 3#1163
Draft
mariobuikhuizen wants to merge 17 commits into
Draft
Conversation
Avoid caching and reusing the vnode returned by widgetView.vueRender() when rendering Vue 3 widgets in the Solara popout wrapper. Vue 3 expects render functions to return fresh vnode instances. Reusing the same vnode can leave event listeners and child component state stale, which broke interactions such as table checkbox updates in popped-out ipyvuetify templates. Cache the returned component type instead, and create a fresh vnode from that stable type on each render. This preserves component identity without remounting the full widget tree on every update.
Use vueComponent() for Vue 3 Vuetify widget views instead of calling vueRender() and reusing the returned VNode. Rendering a stable component keeps the widget view inside Vue's normal component lifecycle and avoids the event instability seen in Solara popouts.
mariobuikhuizen
force-pushed
the
ipyvuetify3
branch
from
abd4730 to
00f782c
Compare
mariobuikhuizen
force-pushed
the
ipyvuetify3
branch
from
fe3d48f to
3c66b04
Compare
mariobuikhuizen
force-pushed
the
ipyvuetify3-py
branch
from
0e95854 to
c266813
Compare
mariobuikhuizen
force-pushed
the
ipyvuetify3-py
branch
from
5090ed2 to
5c0dd1b
Compare
mariobuikhuizen
force-pushed
the
ipyvuetify3-py
branch
3 times, most recently
from
1974061 to
e5d3d06
Compare
mariobuikhuizen
force-pushed
the
ipyvuetify3-py
branch
from
e5d3d06 to
36c74e5
Compare
mariobuikhuizen
force-pushed
the
ipyvuetify3
branch
2 times, most recently
from
03700ca to
c57eab4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
pre-commitprior to committing my changes (see development setup docs).Changes to / New Features:
Description of changes