Skip to content

Make JRuby 10 a required CI target #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etagwerker merged 5 commits into from
Jun 24, 2026
+28 −8
Merged

Make JRuby 10 a required CI target #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c275297
Make JRuby 10 a required CI target
etagwerker Jun 8, 2026
64c52cb
Add CHANGELOG entry for JRuby 10 required CI target
etagwerker Jun 15, 2026
f20d978
Merge branch 'main' into jruby-compatibility
etagwerker Jun 18, 2026
b917700
Add jruby-10.1 as an experimental CI target
etagwerker Jun 19, 2026
f2ee57d
Promote jruby-10.1 to a required CI target
etagwerker Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ jobs:
- '3.3'
- '3.4'
- '4.0'
- 'jruby-10.0'
- 'jruby-10.1'
experimental: [false]
include:
- ruby-version: 'ruby-head'
experimental: true
- ruby-version: 'jruby-10.0'
experimental: true
steps:
- uses: actions/checkout@v6
- name: Set up Ruby ${{ matrix.ruby-version }}
Expand All @@ -63,12 +63,12 @@ jobs:
- '3.3'
- '3.4'
- '4.0'
- 'jruby-10.0'
- 'jruby-10.1'
experimental: [false]
include:
- ruby-version: 'ruby-head'
experimental: true
- ruby-version: 'jruby-10.0'
experimental: true
steps:
- uses: actions/checkout@v6
- name: Set up Ruby ${{ matrix.ruby-version }}
Expand All @@ -94,12 +94,12 @@ jobs:
- '3.3'
- '3.4'
- '4.0'
- 'jruby-10.0'
- 'jruby-10.1'
experimental: [false]
include:
- ruby-version: 'ruby-head'
experimental: true
- ruby-version: 'jruby-10.0'
experimental: true
steps:
- uses: actions/checkout@v6
- name: Set up Ruby ${{ matrix.ruby-version }}
Expand All @@ -125,12 +125,12 @@ jobs:
- '3.3'
- '3.4'
- '4.0'
- 'jruby-10.0'
- 'jruby-10.1'
experimental: [false]
include:
- ruby-version: 'ruby-head'
experimental: true
- ruby-version: 'jruby-10.0'
experimental: true
steps:
- uses: actions/checkout@v6
- name: Set up Ruby ${{ matrix.ruby-version }}
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

* [CHANGE] Replace Aruba with direct API calls in specs (by [@faisal][])
* [CHANGE] Replace all Cucumber features with Minitest/Spec specs (by [@faisal][])
* [CHANGE] Make JRuby 10.0 and 10.1 required CI targets, and fix the test suite's gem load order on JRuby (by [@etagwerker][])
* [BUGFIX] Add `lang="en"` to the report's `<html>` element, give the menu-toggle anchor an `aria-label`, and make the per-rating summary IDs unique. Fixes 17 WCAG 2.1 AA structural errors on `overview.html`. (by [@MarcusAl][])

# v5.0.0 / 2026-01-26 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.12.0...v5.0.0)
Expand Down
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,13 @@ RubyCritic is supporting Ruby versions:
| 3.4 | latest |
| 4.0 | latest |

RubyCritic also runs on JRuby and is tested against it in CI:

| JRuby version | Targeted Ruby compatibility |
| --- | --- |
| 10.0 | 3.4 |
| 10.1 | 4.0 |

## Improving RubyCritic

RubyCritic doesn't have to remain a second choice to other code quality analysis services. Together, we can improve it and continue to build on the great code metric tools that are available in the Ruby ecosystem.
Expand Down
12 changes: 12 additions & 0 deletions test/test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,18 @@
require 'ostruct'
require 'diff/lcs'

# On JRuby, Ruby 3.4's bundled_gems require shim can clobber Zeitwerk's
# implicit-namespace autoloads if a bundled gem (e.g. racc, pulled in by
# ruby_parser/flog) re-wraps Kernel#require after Zeitwerk is set up. When that
# happens, reek's deferred load of dry-schema's `Macros` namespace fails with
# "cannot load such file -- .../dry/schema/macros". Forcing reek's schema to
# load up front, before any flog/ruby_parser require, sidesteps the ordering
# issue. The application itself is unaffected because it loads reek before flog.
if defined?(JRUBY_VERSION)
require 'reek'
Reek::Configuration::Schema
end

def context(...)
describe(...)
end
Expand Down
Loading