refactor(manager): Remove day-id inference workaround from WorkoutLog.save() (#2481) - #2484
Open
pankaj-basnet wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Removes the day-inference workaround added for #2460 .
WorkoutLog.save()no longer guesses a session'sdayfromslot_entry → slot → day, either when auto-creating a session or by re-scanning a session's logs after save.dayis now only ever set from what's explicitly provided — no more extra per-save queries.Migration
0028_backfill_session_day.pyis left untouched;Tests: updated
test_log_model.py— removed inference-behavior tests,Related Issue(s)
Closes #2481.
Please check that the PR fulfills these requirements
ruff format && isort .)changes etc.), write a small writeup in
CHANGELOG.md